From 31df147d64f164437ce96093d8b974a8a891358b Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Wed, 19 Oct 2022 10:59:56 -0700 Subject: [PATCH] RNGP - Make sure GenerateCodegenSchemaTask is not considering generated assets/res for execution avoidance Summary: This is part of a series of tasks to make the React Native Gradle Plugin (RNGP) variant-aware. Here I'm extending the GenerateCodegenSchemaTask to make sure we exclude the generated build/ASSETS and build/RES folders from execution avoidance. Changelog: [Internal] [Changed] - RNGP - Make sure GenerateCodegenSchemaTask is not considering generated assets/res for execution avoidance Reviewed By: cipolleschi Differential Revision: D40512103 fbshipit-source-id: 193f4fd241a0fd973863beb6ff0dd1128dcee1d7 --- .../com/facebook/react/tasks/GenerateCodegenSchemaTask.kt | 2 ++ .../com/facebook/react/tasks/GenerateCodegenSchemaTaskTest.kt | 2 ++ 2 files changed, 4 insertions(+) diff --git a/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/tasks/GenerateCodegenSchemaTask.kt b/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/tasks/GenerateCodegenSchemaTask.kt index 120b82c5e4e..b86b2e2b129 100644 --- a/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/tasks/GenerateCodegenSchemaTask.kt +++ b/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/tasks/GenerateCodegenSchemaTask.kt @@ -38,6 +38,8 @@ abstract class GenerateCodegenSchemaTask : Exec() { // .js files could be stored/generated. We want to make sure we don't pick them up // for execution avoidance. it.exclude("**/generated/source/codegen/**/*") + it.exclude("**/build/ASSETS/**/*") + it.exclude("**/build/RES/**/*") it.exclude("**/build/generated/assets/react/**/*") it.exclude("**/build/generated/res/react/**/*") it.exclude("**/build/generated/sourcemaps/react/**/*") diff --git a/packages/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/tasks/GenerateCodegenSchemaTaskTest.kt b/packages/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/tasks/GenerateCodegenSchemaTaskTest.kt index bc265bd8a31..bf546613fab 100644 --- a/packages/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/tasks/GenerateCodegenSchemaTaskTest.kt +++ b/packages/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/tasks/GenerateCodegenSchemaTaskTest.kt @@ -70,6 +70,8 @@ class GenerateCodegenSchemaTaskTest { assertEquals( setOf( "**/generated/source/codegen/**/*", + "**/build/ASSETS/**/*", + "**/build/RES/**/*", "**/build/generated/assets/react/**/*", "**/build/generated/res/react/**/*", "**/build/generated/sourcemaps/react/**/*",