From 30d5b9dbf57e9bcf7567b6c15db2801387a41a6e Mon Sep 17 00:00:00 2001 From: Dmitry Patsura Date: Wed, 2 Aug 2017 10:08:55 -0700 Subject: [PATCH] RCTNavigatorManager - drop unneeded error callback Summary: Hey! So, I was interested to contibure, and started from todo Thank Closes https://github.com/facebook/react-native/pull/14823 Differential Revision: D5546610 Pulled By: javache fbshipit-source-id: 58e1b67786cbafa20399ac12dde9fcc3920abe94 --- Libraries/Components/Navigation/NavigatorIOS.ios.js | 2 -- React/Views/RCTNavigatorManager.m | 2 -- 2 files changed, 4 deletions(-) diff --git a/Libraries/Components/Navigation/NavigatorIOS.ios.js b/Libraries/Components/Navigation/NavigatorIOS.ios.js index 87daa4ffe3a..a43dd63d4a4 100644 --- a/Libraries/Components/Navigation/NavigatorIOS.ios.js +++ b/Libraries/Components/Navigation/NavigatorIOS.ios.js @@ -25,7 +25,6 @@ var ViewPropTypes = require('ViewPropTypes'); var createReactClass = require('create-react-class'); var invariant = require('fbjs/lib/invariant'); -var logError = require('logError'); var requireNativeComponent = require('requireNativeComponent'); const keyMirror = require('fbjs/lib/keyMirror'); @@ -41,7 +40,6 @@ class NavigatorTransitionerIOS extends React.Component { requestSchedulingNavigation(cb) { RCTNavigatorManager.requestSchedulingJavaScriptNavigation( ReactNative.findNodeHandle(this), - logError, cb ); } diff --git a/React/Views/RCTNavigatorManager.m b/React/Views/RCTNavigatorManager.m index 3b42facb947..ee44a775003 100644 --- a/React/Views/RCTNavigatorManager.m +++ b/React/Views/RCTNavigatorManager.m @@ -29,9 +29,7 @@ RCT_EXPORT_VIEW_PROPERTY(onNavigationProgress, RCTDirectEventBlock) RCT_EXPORT_VIEW_PROPERTY(onNavigationComplete, RCTBubblingEventBlock) RCT_EXPORT_VIEW_PROPERTY(interactivePopGestureEnabled, BOOL) -// TODO: remove error callbacks RCT_EXPORT_METHOD(requestSchedulingJavaScriptNavigation:(nonnull NSNumber *)reactTag - errorCallback:(__unused RCTResponseSenderBlock)errorCallback callback:(RCTResponseSenderBlock)callback) { [self.bridge.uiManager addUIBlock: