Facebook/react-native
1
0 Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Delete C++ ViewManagers

Browse Source 
Summary:
This diff deletes the first implementation of C++ ViewManagers integrated into the internals of Fabric

changelog: [internal] internal

Reviewed By: javache

Differential Revision: D41638894

fbshipit-source-id: 2e7aebff587e2e57b7f3fbf37a24b04943c74573
This commit is contained in:
David Vacca authored and Facebook GitHub Bot committed 2022-12-10 10:30:47 -08:00
1 parent 3ab6274f0d
commit 30d50430a9
6 files changed
+1 -187
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/mountitems/IntBufferBatchMountItem.java
-11
View File
@@ -16,7 +16,6 @@ import com.facebook.common.logging.FLog;
import com.facebook.proguard.annotations.DoNotStrip;
import com.facebook.react.bridge.ReactMarker;
import com.facebook.react.bridge.ReactMarkerConstants;
import com.facebook.react.fabric.CppViewMutationsWrapper;
import com.facebook.react.fabric.events.EventEmitterWrapper;
import com.facebook.react.fabric.mounting.MountingManager;
import com.facebook.react.fabric.mounting.SurfaceMountingManager;
@@ -51,7 +50,6 @@ public class IntBufferBatchMountItem implements MountItem {
static final int INSTRUCTION_UPDATE_PADDING = 512;
static final int INSTRUCTION_UPDATE_OVERFLOW_INSET = 1024;
static final int INSTRUCTION_REMOVE_DELETE_TREE = 2048;
static final int INSTRUCTION_RUN_CPP_VIEWS = 4096;
private final int mSurfaceId;
private final int mCommitNumber;
@@ -99,10 +97,6 @@ public class IntBufferBatchMountItem implements MountItem {
return obj != null ? (EventEmitterWrapper) obj : null;
}
private static CppViewMutationsWrapper castToCppViewMutationWrapper(Object obj) {
return obj != null ? (CppViewMutationsWrapper) obj : null;
}
@Override
public void execute(@NonNull MountingManager mountingManager) {
SurfaceMountingManager surfaceMountingManager = mountingManager.getSurfaceManager(mSurfaceId);
@@ -184,8 +178,6 @@ public class IntBufferBatchMountItem implements MountItem {
} else if (type == INSTRUCTION_UPDATE_EVENT_EMITTER) {
surfaceMountingManager.updateEventEmitter(
mIntBuffer[i++], castToEventEmitter(mObjBuffer[j++]));
} else if (type == INSTRUCTION_RUN_CPP_VIEWS) {
castToCppViewMutationWrapper(mObjBuffer[j++]).runCppViewMutations();
} else {
throw new IllegalArgumentException(
"Invalid type argument to IntBufferBatchMountItem: " + type + " at index: " + i);
@@ -286,9 +278,6 @@ public class IntBufferBatchMountItem implements MountItem {
} else if (type == INSTRUCTION_UPDATE_EVENT_EMITTER) {
j += 1;
s.append(String.format("UPDATE EVENTEMITTER [%d]\n", mIntBuffer[i++]));
} else if (type == INSTRUCTION_RUN_CPP_VIEWS) {
j += 1;
s.append(String.format("RUN CPP_VIEWS [%d]\n", mIntBuffer[i++]));
} else {
FLog.e(TAG, "String so far: " + s.toString());
throw new IllegalArgumentException(