From 3077db32ef060aba85d9b56bd2a9f81a7afba985 Mon Sep 17 00:00:00 2001 From: Alex Hunt Date: Wed, 28 Aug 2024 03:20:17 -0700 Subject: [PATCH] Update references to debugger frontend (#46232) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46232 Follows D61711818. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D61852414 fbshipit-source-id: a2d7f135a3ff03751c6d91978bebee007272f306 --- .../src/middleware/openDebuggerMiddleware.js | 10 +++++----- .../ReactCommon/jsinspector-modern/HostAgent.cpp | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/dev-middleware/src/middleware/openDebuggerMiddleware.js b/packages/dev-middleware/src/middleware/openDebuggerMiddleware.js index 174943d3102..69051ec09c3 100644 --- a/packages/dev-middleware/src/middleware/openDebuggerMiddleware.js +++ b/packages/dev-middleware/src/middleware/openDebuggerMiddleware.js @@ -87,7 +87,7 @@ export default function openDebuggerMiddleware({ ) { logger?.info( (launchType === 'launch' ? 'Launching' : 'Redirecting to') + - ' JS debugger (experimental)...', + ' DevTools...', ); target = targets.find( _target => @@ -98,16 +98,16 @@ export default function openDebuggerMiddleware({ } else if (targets.length > 0) { logger?.info( (launchType === 'launch' ? 'Launching' : 'Redirecting to') + - ` JS debugger${targets.length === 1 ? '' : ' for most recently connected target'}...`, + ` DevTools${targets.length === 1 ? '' : ' for most recently connected target'}...`, ); target = targets[targets.length - 1]; } if (!target) { res.writeHead(404); - res.end('Unable to find Chrome DevTools inspector target'); + res.end('Unable to find debugger target'); logger?.warn( - 'No compatible apps connected. JavaScript debugging can only be used with the Hermes engine.', + 'No compatible apps connected. React Native DevTools can only be used with the Hermes engine.', ); eventReporter?.logEvent({ type: 'launch_debugger_frontend', @@ -160,7 +160,7 @@ export default function openDebuggerMiddleware({ return; } catch (e) { logger?.error( - 'Error launching JS debugger: ' + e.message ?? 'Unknown error', + 'Error launching DevTools: ' + e.message ?? 'Unknown error', ); res.writeHead(500); res.end(); diff --git a/packages/react-native/ReactCommon/jsinspector-modern/HostAgent.cpp b/packages/react-native/ReactCommon/jsinspector-modern/HostAgent.cpp index 7d0cb50d9ab..ede1ad3af35 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/HostAgent.cpp +++ b/packages/react-native/ReactCommon/jsinspector-modern/HostAgent.cpp @@ -221,9 +221,9 @@ HostAgent::~HostAgent() { } void HostAgent::sendFuseboxNotice() { - static constexpr auto kFuseboxNotice = ANSI_COLOR_BG_YELLOW - "Welcome to " ANSI_WEIGHT_BOLD "React Native DevTools" ANSI_WEIGHT_RESET - " (experimental)"sv; + static constexpr auto kFuseboxNotice = + ANSI_COLOR_BG_YELLOW "Welcome to " ANSI_WEIGHT_BOLD + "React Native DevTools" ANSI_WEIGHT_RESET ""sv; sendInfoLogEntry(kFuseboxNotice); } @@ -233,7 +233,7 @@ void HostAgent::sendNonFuseboxNotice() { ANSI_COLOR_BG_YELLOW ANSI_WEIGHT_BOLD "NOTE: " ANSI_WEIGHT_RESET "You are using an unsupported debugging client. " - "Use the Dev Menu in your app (or type `j` in the Metro terminal) to open the latest, supported React Native debugger."sv; + "Use the Dev Menu in your app (or type `j` in the Metro terminal) to open React Native DevTools."sv; std::vector args; args.emplace_back(kNonFuseboxNotice);