Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix TextInput padding on Nodes

Browse Source 
Summary:
Fix TextInput padding on Nodes. We used to not call super and used
to manually do the setting of padding. This stops us from running the same
logic that non-Nodes runs (we bypassed it), so this fixes it.

Reviewed By: astreet

Differential Revision: D3825227
This commit is contained in:
Ahmed El-Helw
2016-12-19 13:40:33 -08:00
parent 558f934f44
commit 3061606fe6
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/flat/RCTTextInput.java
+3 -5
View File
@@ -18,7 +18,6 @@ import android.util.TypedValue;
import android.view.ViewGroup;
import android.widget.EditText;
import com.facebook.csslayout.CSSDirection;
import com.facebook.csslayout.CSSMeasureMode;
import com.facebook.csslayout.CSSNodeAPI;
import com.facebook.csslayout.MeasureOutput;
@@ -154,10 +153,9 @@ public class RCTTextInput extends RCTVirtualText implements AndroidView, CSSNode
@Override
public void setPadding(int spacingType, float padding) {
if (getPadding().set(spacingType, padding)) {
mPaddingChanged = true;
dirty();
}
super.setPadding(spacingType, padding);
mPaddingChanged = true;
dirty();
}
@Override