From 2ffb11bacb11f23a55867311c73dafa4f3e169d6 Mon Sep 17 00:00:00 2001
From: Lu Su <lusu@meta.com>
Date: Fri, 5 May 2023 20:36:43 -0700
Subject: [PATCH] Fix broken android extraction/translation pipeline (#37292)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37292

<level:mustfix> <name:i18n.error> Failed extracting strings from file: <../xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/res/devsupport/values/strings.xml>
From IntlAndroidResourceExtractionException: Failed extracting resource catalyst_dev_menu_header
From InvariantViolationException: Format specifiers must be wrapped by an xliff:g tag
(FBLogger Parent Frame: /var/sandcastle/deployment/mount/54023/flib/intern/intl/extraction/StringExtractionLogger.php:43)

https://www.internalfb.com/skycastle/run/1932044240142241285/insights

Changelog:
[Internal] [Changed] - Fix broken pipelines

Differential Revision: D45615679

fbshipit-source-id: 64b2bae542c6bd0e3d5e25d3054ea916d52b0325
---
 .../ReactAndroid/src/main/res/devsupport/values/strings.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/react-native/ReactAndroid/src/main/res/devsupport/values/strings.xml b/packages/react-native/ReactAndroid/src/main/res/devsupport/values/strings.xml
index 03cb42fbf3c..6149af00047 100644
--- a/packages/react-native/ReactAndroid/src/main/res/devsupport/values/strings.xml
+++ b/packages/react-native/ReactAndroid/src/main/res/devsupport/values/strings.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<resources>
+<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
   <string name="catalyst_reload" project="catalyst" translatable="false">Reload</string>
   <string name="catalyst_reload_error" project="catalyst" translatable="false">Failed to load bundle. Try restarting the bundler or reconnecting your device.</string>
   <string name="catalyst_change_bundle_location" project="catalyst" translatable="false">Change Bundle Location</string>
@@ -26,6 +26,6 @@
   <string name="catalyst_loading_from_url" project="catalyst" translatable="false">Loading from %1$s…</string>
   <string name="catalyst_sample_profiler_disable" project="catalyst" translatable="false">Disable Sampling Profiler</string>
   <string name="catalyst_sample_profiler_enable" project="catalyst" translatable="false">Enable Sampling Profiler</string>
-  <string name="catalyst_dev_menu_header">React Native Dev Menu (%1$s)</string>
-  <string name="catalyst_dev_menu_sub_header">Running %1$s</string>
+  <string name="catalyst_dev_menu_header">React Native Dev Menu <xliff:g id="menu_header_name">(%1$s)</xliff:g></string>
+  <string name="catalyst_dev_menu_sub_header">Running <xliff:g id="menu_sub_header_name">%1$s</xliff:g></string>
 </resources>