From 2fa0494bc4236f4f21b1de51618f8730af599e81 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Fri, 24 Jan 2025 10:15:58 -0800 Subject: [PATCH] Internalize ReactNativeFeatureFlags generated accessor classes (#48909) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48909 Internalize ReactNativeFeatureFlags generated accessor classes changelog: [internal] internal Reviewed By: cortinico Differential Revision: D68579670 fbshipit-source-id: 63606793e2a63f1901c7de2cb40e68c27193259d --- .../featureflags/ReactNativeFeatureFlagsCxxAccessor.kt | 4 ++-- .../featureflags/ReactNativeFeatureFlagsLocalAccessor.kt | 4 ++-- .../android/ReactNativeFeatureFlagsCxxAccessor.kt-template.js | 2 +- .../ReactNativeFeatureFlagsLocalAccessor.kt-template.js | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt index 90eefe210e2..9ea6203a7d5 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<> + * @generated SignedSource<> */ /** @@ -19,7 +19,7 @@ package com.facebook.react.internal.featureflags -public class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAccessor { +internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAccessor { private var commonTestFlagCache: Boolean? = null private var completeReactInstanceCreationOnBgThreadOnAndroidCache: Boolean? = null private var disableMountItemReorderingAndroidCache: Boolean? = null diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt index 82bf265841c..788b3f67cc1 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<> + * @generated SignedSource<<196d9ffaf89a44b190d2513c0a1fb0e1>> */ /** @@ -19,7 +19,7 @@ package com.facebook.react.internal.featureflags -public class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAccessor { +internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAccessor { private var currentProvider: ReactNativeFeatureFlagsProvider = ReactNativeFeatureFlagsDefaults() private val accessedFeatureFlags = mutableSetOf() diff --git a/packages/react-native/scripts/featureflags/templates/android/ReactNativeFeatureFlagsCxxAccessor.kt-template.js b/packages/react-native/scripts/featureflags/templates/android/ReactNativeFeatureFlagsCxxAccessor.kt-template.js index 71b7ce3ce25..1123654b955 100644 --- a/packages/react-native/scripts/featureflags/templates/android/ReactNativeFeatureFlagsCxxAccessor.kt-template.js +++ b/packages/react-native/scripts/featureflags/templates/android/ReactNativeFeatureFlagsCxxAccessor.kt-template.js @@ -30,7 +30,7 @@ ${DO_NOT_MODIFY_COMMENT} package com.facebook.react.internal.featureflags -public class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAccessor { +internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAccessor { ${Object.entries(definitions.common) .map( ([flagName, flagConfig]) => diff --git a/packages/react-native/scripts/featureflags/templates/android/ReactNativeFeatureFlagsLocalAccessor.kt-template.js b/packages/react-native/scripts/featureflags/templates/android/ReactNativeFeatureFlagsLocalAccessor.kt-template.js index b731aee4e84..988125e9f32 100644 --- a/packages/react-native/scripts/featureflags/templates/android/ReactNativeFeatureFlagsLocalAccessor.kt-template.js +++ b/packages/react-native/scripts/featureflags/templates/android/ReactNativeFeatureFlagsLocalAccessor.kt-template.js @@ -30,7 +30,7 @@ ${DO_NOT_MODIFY_COMMENT} package com.facebook.react.internal.featureflags -public class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAccessor { +internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAccessor { private var currentProvider: ReactNativeFeatureFlagsProvider = ReactNativeFeatureFlagsDefaults() private val accessedFeatureFlags = mutableSetOf()