From 2edb9280591a984e23e16cb09c2ca63a2fee2af9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateo=20Guzm=C3=A1n?= Date: Mon, 14 Apr 2025 08:28:41 -0700 Subject: [PATCH] Make `DrawerClosedEvent` internal (#50689) Summary: This class can be internalized as part of the initiative to reduce the public API surface. I've checked there are [no relevant OSS usages](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+NOT+user%3Acortinico+NOT+repo%3AMaxdev18%2Fpowersync_app+NOT+repo%3Acarter-0%2Finstagram-decompiled+NOT+repo%3Am0mosenpai%2Finstadamn+NOT+repo%3AA-Star100%2FA-Star100-AUG2-2024+NOT+repo%3Alclnrd%2Fdetox-scrollview-reproductible+NOT+repo%3ADionisisChytiris%2FWorldWiseTrivia_Main+NOT+repo%3Apast3l%2Fhi2+NOT+repo%3AoneDotpy%2FCaribouQuest+NOT+repo%3Abejayoharen%2Fdailytodo+NOT+repo%3Amolangning%2Freversing-discord+NOT+repo%3AScottPrzy%2Freact-native+NOT+repo%3Agabrieldonadel%2Freact-native-visionos+NOT+repo%3AGabriel2308%2FTestes-Soft+NOT+repo%3Adawnzs03%2FflakyBuild+NOT+repo%3Acga2351%2Fcode+NOT+repo%3Astreeg%2Ftcc+NOT+repo%3Asoftware-mansion-labs%2Freact-native-swiftui+NOT+repo%3Apkcsecurity%2Fdecompiled-lightbulb+com.facebook.react.views.drawer.events.DrawerClosedEvent). ## Changelog: [INTERNAL] - Make com.facebook.react.views.drawer.events.DrawerClosedEvent internal Pull Request resolved: https://github.com/facebook/react-native/pull/50689 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: rshest Differential Revision: D72959868 Pulled By: cortinico fbshipit-source-id: 6a9c1f408b821afb753b514d5d9e7cbd2079e8ea --- .../react-native/ReactAndroid/api/ReactAndroid.api | 11 ----------- .../react/views/drawer/events/DrawerClosedEvent.kt | 12 ++++++------ 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index 7f7c94ad829..a30e55e2d9a 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -5553,17 +5553,6 @@ public final class com/facebook/react/views/drawer/ReactDrawerLayoutManager : co public final class com/facebook/react/views/drawer/ReactDrawerLayoutManager$Companion { } -public final class com/facebook/react/views/drawer/events/DrawerClosedEvent : com/facebook/react/uimanager/events/Event { - public static final field Companion Lcom/facebook/react/views/drawer/events/DrawerClosedEvent$Companion; - public static final field EVENT_NAME Ljava/lang/String; - public fun (I)V - public fun (II)V - public fun getEventName ()Ljava/lang/String; -} - -public final class com/facebook/react/views/drawer/events/DrawerClosedEvent$Companion { -} - public final class com/facebook/react/views/drawer/events/DrawerOpenedEvent : com/facebook/react/uimanager/events/Event { public static final field Companion Lcom/facebook/react/views/drawer/events/DrawerOpenedEvent$Companion; public static final field EVENT_NAME Ljava/lang/String; diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/drawer/events/DrawerClosedEvent.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/drawer/events/DrawerClosedEvent.kt index 8bbcf0440dd..f36e4e70fc0 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/drawer/events/DrawerClosedEvent.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/drawer/events/DrawerClosedEvent.kt @@ -12,18 +12,18 @@ import com.facebook.react.bridge.WritableMap import com.facebook.react.uimanager.common.ViewUtil import com.facebook.react.uimanager.events.Event -public class DrawerClosedEvent : Event { +internal class DrawerClosedEvent : Event { @Deprecated("Use constructor with surfaceId", ReplaceWith("DrawerClosedEvent(surfaceId, viewId)")) - public constructor(viewId: Int) : this(ViewUtil.NO_SURFACE_ID, viewId) + constructor(viewId: Int) : this(ViewUtil.NO_SURFACE_ID, viewId) - public constructor(surfaceId: Int, viewId: Int) : super(surfaceId, viewId) + constructor(surfaceId: Int, viewId: Int) : super(surfaceId, viewId) - public override fun getEventName(): String = EVENT_NAME + override fun getEventName(): String = EVENT_NAME protected override fun getEventData(): WritableMap? = Arguments.createMap() - public companion object { - public const val EVENT_NAME: String = "topDrawerClose" + companion object { + const val EVENT_NAME: String = "topDrawerClose" } }