From 2d67b723d38dfd3600303b29df635e0a4703f460 Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Mon, 15 Jul 2024 13:05:40 -0700 Subject: [PATCH] Gate off "mixBlendMode" and "filter" on Paper (#45443) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45443 We are only building these out for Fabric. This means only one natural iOS impl, but that other Android bits will not work fully correctly on Paper (like setting containing block for filter element). This also means we can remove view configs once we're on Fabric CSS parser. We will do the same for boxShadow once that is ready. Changelog: [internal] Reviewed By: mdvacca Differential Revision: D59762282 fbshipit-source-id: 14ce07f04b822c6aee908894c9081419594fc484 --- .../react-native/ReactAndroid/api/ReactAndroid.api | 1 + .../com/facebook/react/uimanager/BaseViewManager.java | 10 ++++++++-- .../com/facebook/react/uimanager/common/ViewUtil.kt | 8 ++++++++ 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index 88077b2e3e9..b6c5c7d47f5 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -5531,6 +5531,7 @@ public final class com/facebook/react/uimanager/common/ViewUtil { public static final field NO_SURFACE_ID I public static final fun getUIManagerType (I)I public static final fun getUIManagerType (II)I + public static final fun getUIManagerType (Landroid/view/View;)I public static final fun isRootTag (I)Z } diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java index c0019a2dbfc..84bf68d23d0 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java @@ -31,6 +31,8 @@ import com.facebook.react.common.ReactConstants; import com.facebook.react.uimanager.ReactAccessibilityDelegate.AccessibilityRole; import com.facebook.react.uimanager.ReactAccessibilityDelegate.Role; import com.facebook.react.uimanager.annotations.ReactProp; +import com.facebook.react.uimanager.common.UIManagerType; +import com.facebook.react.uimanager.common.ViewUtil; import com.facebook.react.uimanager.events.PointerEventHelper; import com.facebook.react.uimanager.util.ReactFindViewUtil; import java.util.ArrayList; @@ -190,13 +192,17 @@ public abstract class BaseViewManager