From 2c540ac35a809925f55a1f4deaab98802bda3532 Mon Sep 17 00:00:00 2001 From: Ruslan Lesiutin Date: Thu, 31 Jul 2025 07:43:31 -0700 Subject: [PATCH] Add a method for transfering an ownership of captured TraceEvents (#52940) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/52940 # Changelog: [Internal] This is required for storing these Trace Events somewhere outside of PerformanceTracer, in case these events will be dispatched later. Reviewed By: rubennorte Differential Revision: D78741192 fbshipit-source-id: 3cc2eacd922855231fafb93c32d326b150b3c19b --- .../jsinspector-modern/tracing/PerformanceTracer.cpp | 9 +++++++++ .../jsinspector-modern/tracing/PerformanceTracer.h | 6 ++++++ 2 files changed, 15 insertions(+) diff --git a/packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp b/packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp index 16650e2ed41..e287b6f584d 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp +++ b/packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp @@ -131,6 +131,15 @@ folly::dynamic PerformanceTracer::collectEvents(uint16_t chunkSize) { return chunks; } +std::vector PerformanceTracer::collectTraceEvents() { + std::vector events; + { + std::lock_guard lock(mutex_); + buffer_.swap(events); + } + return events; +} + void PerformanceTracer::reportMark( const std::string_view& name, HighResTimeStamp start, diff --git a/packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.h b/packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.h index a94e548be96..088f98a7758 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.h +++ b/packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.h @@ -65,6 +65,12 @@ class PerformanceTracer { */ folly::dynamic collectEvents(uint16_t chunkSize); + /** + * Transfers an ownership of all buffered TraceEvents, the local buffer state + * is invalidated after this call. + */ + std::vector collectTraceEvents(); + /** * Record a `Performance.mark()` event - a labelled timestamp. If not * currently tracing, this is a no-op.