From 2bed2ab1a658230cb6fa23fdcb4e5a962f496e18 Mon Sep 17 00:00:00 2001
From: Nick Gerleman <ngerlem@meta.com>
Date: Tue, 9 Jul 2024 14:59:40 -0700
Subject: [PATCH] Fix ReactImageView.hasOverlappingRendering() (#45352)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/45352

We claim that we will never draw multiple elements on top of each other, which isn't correct when we have a background.

We should claim that we can draw overlapping elements if we have a background drawable which we place in the Drawee hierarchy (part of the ImageView foreground drawable), or if the underlying view has a background drawable (which is handled by `ImageView` superclass `hasOverlappingRendering()`).

The effect of this is subtle, and just means that we get correct compositing when an opacity is set on image with background.

Changelog:
[Android][Fixed] - Fix ReactImageView.hasOverlappingRendering()

Reviewed By: mdvacca

Differential Revision: D59489788

fbshipit-source-id: fe2922f064b91f1709ed546dd647d4d4112d04c1
---
 .../java/com/facebook/react/views/image/ReactImageView.java    | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageView.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageView.java
index d02b91663b7..0162bd08247 100644
--- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageView.java
+++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageView.java
@@ -567,10 +567,9 @@ public class ReactImageView extends GenericDraweeView {
     }
   }
 
-  /** ReactImageViews only render a single image. */
   @Override
   public boolean hasOverlappingRendering() {
-    return false;
+    return mBackgroundImageDrawable != null || super.hasOverlappingRendering();
   }
 
   private boolean hasMultipleSources() {