From 2b845d5585c08355ca14c424a424c68f0cf1c62e Mon Sep 17 00:00:00 2001 From: David Vacca Date: Mon, 14 Feb 2022 11:17:40 -0800 Subject: [PATCH] Integrate DeviceConfig into ReactNativePanelApps Summary: This diff integrates DeviceConfig into ReactNativeConfig used by ReactNativePanelApps. The goal is to be able to control Fabric MCs using GKs and QEs in RN VR apps I did an audit of the MCs that were used by RNPanelApps: ``` "react_fabric:enabled_android_fabric_logs": -> will get data from GK (disabled by default) "react_fabric:disable_virtual_node_preallocation": -> does not exist in code anymore "react_fabric:enable_early_event_emitter_update": -> will get data from MC (disabled using static value) "react_fabric:enable_background_executor_android": -> does not exist in code anymore "react_fabric:enable_props_forwarding_android": -> does not exist in code anymore "react_fabric:remove_outstanding_surfaces_on_destruction_android": -> will get data from MC static value (ENABLED using static value) "react_fabric:enable_large_text_measure_cache_android": -> will get data from MC default value (ENABLED by default) ``` changelog: [internal] internal Reviewed By: JoshuaGross Differential Revision: D33898210 fbshipit-source-id: 0ea1e0e2fc15929bec328f7dcc9410efa9925b34 --- .../src/main/java/com/facebook/react/ReactInstanceManager.java | 1 + 1 file changed, 1 insertion(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java index e5743ca5a92..e98a41716fb 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java @@ -1012,6 +1012,7 @@ public class ReactInstanceManager { mReactInstanceEventListeners.remove(listener); } + /** @return current ReactApplicationContext */ @VisibleForTesting public @Nullable ReactContext getCurrentReactContext() { synchronized (mReactContextLock) {