From 2af406b88d4256d0f4cddbe6ffee0f45be5b2509 Mon Sep 17 00:00:00 2001 From: Alessandro Sisto Date: Fri, 6 Nov 2020 05:46:49 -0800 Subject: [PATCH] Revert D24685389: Set up experiment to dispatch promise methods asynchronously to NativeModules thread Differential Revision: D24685389 (https://github.com/facebook/react-native/commit/052e578ed666f2749ec06d1d928bb622cada8841) Original commit changeset: 8ceb2e6effc1 fbshipit-source-id: e48186dd0e928fe95cc7f2420fc02c00a62b8360 --- .../main/java/com/facebook/react/config/ReactFeatureFlags.java | 3 --- .../facebook/react/turbomodule/core/TurboModuleManager.java | 3 +-- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java b/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java index 9d8f1c4859a..04a8a88eb5c 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java +++ b/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java @@ -23,9 +23,6 @@ public class ReactFeatureFlags { */ public static volatile boolean useTurboModules = false; - /** Should we dispatch TurboModule methods with promise returns to the NativeModules thread? */ - public static volatile boolean enableTurboModulePromiseAsyncDispatch = false; - /* * This feature flag enables logs for Fabric */ diff --git a/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManager.java b/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManager.java index 8303d153f61..e6e6fcce69e 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManager.java @@ -17,7 +17,6 @@ import com.facebook.react.bridge.CxxModuleWrapper; import com.facebook.react.bridge.JSIModule; import com.facebook.react.bridge.JavaScriptContextHolder; import com.facebook.react.bridge.NativeModule; -import com.facebook.react.config.ReactFeatureFlags; import com.facebook.react.turbomodule.core.interfaces.CallInvokerHolder; import com.facebook.react.turbomodule.core.interfaces.TurboModule; import com.facebook.react.turbomodule.core.interfaces.TurboModuleRegistry; @@ -61,7 +60,7 @@ public class TurboModuleManager implements JSIModule, TurboModuleRegistry { (CallInvokerHolderImpl) jsCallInvokerHolder, (CallInvokerHolderImpl) nativeCallInvokerHolder, delegate, - ReactFeatureFlags.enableTurboModulePromiseAsyncDispatch); + false); installJSIBindings(); mEagerInitModuleNames =