From 2aeeb806f17396d2fe7ffcfe1c85c241b2a839b9 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Wed, 15 Nov 2023 22:43:49 -0800 Subject: [PATCH] Mark uimanager annotations as deprecated in new architecture Summary: This diff marks uimanager annotations as deprecated in new architecture becasue we've decided the native codegen will not be addopted in new architecture bypass-github-export-checks changelog: [internal] internal Reviewed By: rshest Differential Revision: D51262580 fbshipit-source-id: 1248117ca697c612c89062fcee56788cce40a1ae --- .../com/facebook/react/uimanager/annotations/ReactProp.java | 2 ++ .../facebook/react/uimanager/annotations/ReactPropGroup.java | 2 ++ .../react/uimanager/annotations/ReactPropertyHolder.java | 2 ++ 3 files changed, 6 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/annotations/ReactProp.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/annotations/ReactProp.java index b3f7e8fa417..fd195098606 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/annotations/ReactProp.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/annotations/ReactProp.java @@ -10,6 +10,7 @@ package com.facebook.react.uimanager.annotations; import static java.lang.annotation.RetentionPolicy.RUNTIME; import androidx.annotation.Nullable; +import com.facebook.react.common.annotations.DeprecatedInNewArchitecture; import java.lang.annotation.ElementType; import java.lang.annotation.Retention; import java.lang.annotation.Target; @@ -46,6 +47,7 @@ import java.lang.annotation.Target; */ @Retention(RUNTIME) @Target(ElementType.METHOD) +@DeprecatedInNewArchitecture public @interface ReactProp { // Used as a default value for "customType" property as "null" is not allowed. Moreover, when this diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/annotations/ReactPropGroup.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/annotations/ReactPropGroup.java index e4a301fe89b..f157dbdf9c2 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/annotations/ReactPropGroup.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/annotations/ReactPropGroup.java @@ -10,6 +10,7 @@ package com.facebook.react.uimanager.annotations; import static java.lang.annotation.RetentionPolicy.RUNTIME; import androidx.annotation.Nullable; +import com.facebook.react.common.annotations.DeprecatedInNewArchitecture; import java.lang.annotation.ElementType; import java.lang.annotation.Retention; import java.lang.annotation.Target; @@ -40,6 +41,7 @@ import java.lang.annotation.Target; * provided as a default. */ @Retention(RUNTIME) +@DeprecatedInNewArchitecture @Target(ElementType.METHOD) public @interface ReactPropGroup { diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/annotations/ReactPropertyHolder.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/annotations/ReactPropertyHolder.java index 311388ca364..d2a6576a13a 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/annotations/ReactPropertyHolder.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/annotations/ReactPropertyHolder.java @@ -7,6 +7,7 @@ package com.facebook.react.uimanager.annotations; +import com.facebook.react.common.annotations.DeprecatedInNewArchitecture; import java.lang.annotation.ElementType; import java.lang.annotation.Inherited; import java.lang.annotation.Retention; @@ -16,4 +17,5 @@ import java.lang.annotation.Target; @Inherited @Retention(RetentionPolicy.CLASS) @Target(ElementType.TYPE) +@DeprecatedInNewArchitecture public @interface ReactPropertyHolder {}