From 2ac997abcc021d9bc818ad703492fa91cf9071fc Mon Sep 17 00:00:00 2001 From: Blake Friedman Date: Mon, 19 Aug 2024 09:19:35 -0700 Subject: [PATCH] Remove references to old template (#46082) Summary: ## Summary There are old references to the react-native/template. This code has moved to react-native-community/template. Changelog: [Internal] Pull Request resolved: https://github.com/facebook/react-native/pull/46082 Test Plan: CI closes facebook/metro#1324 Reviewed By: cipolleschi Differential Revision: D61472439 Pulled By: blakef fbshipit-source-id: fc40145c03002a7c3117b72d07981a96aa3d8760 --- .eslintrc.js | 7 ------- .flowconfig | 3 +-- .gitignore | 6 ------ jest.config.js | 1 - packages/community-cli-plugin/src/utils/loadMetroConfig.js | 2 +- scripts/releases/__tests__/remove-new-arch-flags-test.js | 4 ++-- scripts/releases/remove-new-arch-flags.js | 2 +- 7 files changed, 5 insertions(+), 20 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index d1335831550..4c434aab38a 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -34,13 +34,6 @@ module.exports = { 'no-undef': 0, }, }, - { - files: ['*.js', '*.js.flow'], - excludedFiles: ['packages/react-native/template/**/*'], - rules: { - 'lint/sort-imports': 1, - }, - }, { files: ['package.json'], parser: 'jsonc-eslint-parser', diff --git a/.flowconfig b/.flowconfig index 0c9a3f2e5c4..e7d30ce810f 100644 --- a/.flowconfig +++ b/.flowconfig @@ -1,6 +1,5 @@ [ignore] -; Ignore templates for 'react-native init' -/packages/react-native/template/.* +; Ignore build cache folder /packages/react-native/sdks/.* ; Ignore the codegen e2e tests diff --git a/.gitignore b/.gitignore index 5851f3674d5..e734a3cffbb 100644 --- a/.gitignore +++ b/.gitignore @@ -39,8 +39,6 @@ project.xcworkspace /packages/react-native/ReactAndroid/external-artifacts/artifacts/ /packages/react-native/ReactAndroid/hermes-engine/build/ /packages/react-native/ReactAndroid/hermes-engine/.cxx/ -/packages/react-native/template/android/app/build/ -/packages/react-native/template/android/build/ /packages/helloworld/android/app/build/ /packages/helloworld/android/build/ /packages/react-native-popup-menu-android/android/build/ @@ -108,16 +106,12 @@ package-lock.json # Ruby Gems (Bundler) /packages/react-native/vendor -/packages/react-native/template/vendor /packages/helloworld/vendor .ruby-version /**/.ruby-version vendor/ # iOS / CocoaPods -/packages/react-native/template/ios/build/ -/packages/react-native/template/ios/Pods/ -/packages/react-native/template/ios/Podfile.lock /packages/helloworld/ios/build/ /packages/helloworld/ios/Pods/ /packages/helloworld/ios/Podfile.lock diff --git a/jest.config.js b/jest.config.js index f81a4049d9a..d4ac1188db3 100644 --- a/jest.config.js +++ b/jest.config.js @@ -30,7 +30,6 @@ module.exports = { testRegex: '/__tests__/.*-test(\\.fb)?\\.js$', testPathIgnorePatterns: [ '/node_modules/', - '/packages/react-native/template', '/packages/react-native/sdks', '/packages/react-native/Libraries/Renderer', '/packages/react-native-test-renderer/src', diff --git a/packages/community-cli-plugin/src/utils/loadMetroConfig.js b/packages/community-cli-plugin/src/utils/loadMetroConfig.js index 52fb398795a..3d116c4946b 100644 --- a/packages/community-cli-plugin/src/utils/loadMetroConfig.js +++ b/packages/community-cli-plugin/src/utils/loadMetroConfig.js @@ -99,7 +99,7 @@ export default async function loadMetroConfig( ================================================================================================= From React Native 0.73, your project's Metro config should extend '@react-native/metro-config' or it will fail to build. Please copy the template at: -https://github.com/facebook/react-native/blob/main/packages/react-native/template/metro.config.js +https://github.com/react-native-community/template/blob/main/template/metro.config.js This warning will be removed in future (https://github.com/facebook/metro/issues/1018). ================================================================================================= `; diff --git a/scripts/releases/__tests__/remove-new-arch-flags-test.js b/scripts/releases/__tests__/remove-new-arch-flags-test.js index 56b6b1ec417..8497f6faf9e 100644 --- a/scripts/releases/__tests__/remove-new-arch-flags-test.js +++ b/scripts/releases/__tests__/remove-new-arch-flags-test.js @@ -37,7 +37,7 @@ describe('removeNewArchFlags', () => { const reactNativePodsPath = '/packages/react-native/scripts/react_native_pods.rb'; const templateGradlePropertiesPath = - '/packages/react-native/template/android/gradle.properties'; + '/packages/helloworld/android/gradle.properties'; jest.spyOn(process, 'cwd').mockReturnValue(cwd); jest.spyOn(fs, 'readFileSync').mockImplementation(filename => { if (filename === path.join(cwd, reactNativePodsPath)) { @@ -89,7 +89,7 @@ describe('removeNewArchFlags', () => { const reactNativePodsPath = '/packages/react-native/scripts/react_native_pods.rb'; const templateGradlePropertiesPath = - '/packages/react-native/template/android/gradle.properties'; + '/packages/helloworld/android/gradle.properties'; jest.spyOn(process, 'cwd').mockReturnValue(cwd); jest.spyOn(fs, 'readFileSync').mockImplementation(filename => { if (filename === path.join(cwd, reactNativePodsPath)) { diff --git a/scripts/releases/remove-new-arch-flags.js b/scripts/releases/remove-new-arch-flags.js index e3ec18d84c5..86a2eb3d62e 100644 --- a/scripts/releases/remove-new-arch-flags.js +++ b/scripts/releases/remove-new-arch-flags.js @@ -87,7 +87,7 @@ function flipNewArchFlagForAndroid( // Gradle.properties const gradlePropertiesPath = path.join( cwd, - '/packages/react-native/template/android/gradle.properties', + '/packages/helloworld/android/gradle.properties', ); backupPath.push( replaceContentsOfFile(