Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make RCTDevLoadingView TurboModule-compatible

Browse Source 
Summary:
RCTDevLoadingView wasn't hooked up to the codegen. This diff makes RCTDevLoadingView type-safe and also makes it TurboModule-compatible.

Changelog:
[iOS][Added] - Make RCTDevLoadingView TurboModule-compatible

Reviewed By: PeteTheHeat

Differential Revision: D16969764

fbshipit-source-id: 47e6682eea3fc49d3f0448c636b5f616d5bce220
This commit is contained in:
Ramanpreet Nara
2019-11-20 11:20:12 -08:00
committed by Facebook Github Bot
parent 55cb6ab07c
commit 294e31b7c2
10 changed files with 77 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeDevLoadingViewSpec.java
+1 -2
View File
@@ -16,7 +16,6 @@ import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReactContextBaseJavaModule;
import com.facebook.react.bridge.ReactMethod;
import com.facebook.react.bridge.ReactModuleWithSpec;
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.turbomodule.core.interfaces.TurboModule;
public abstract class NativeDevLoadingViewSpec extends ReactContextBaseJavaModule implements ReactModuleWithSpec, TurboModule {
@@ -28,5 +27,5 @@ public abstract class NativeDevLoadingViewSpec extends ReactContextBaseJavaModul
public abstract void hide();
@ReactMethod
public abstract void showMessage(String message, ReadableMap color, ReadableMap backgroundColor);
public abstract void showMessage(String message, Double color, Double backgroundColor);
}