Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix NVC for RCTSlider

Browse Source 
Summary:
## Android Failures
```
LOG  SVC RCTSlider Invalid
 LOG  {
  "missing": {
    "directEventTypes": {
      "topSlidingComplete": {
        "registrationName": "onSlidingComplete"
      }
    }
  },
  "unexpected": {
    "bubblingEventTypes": {
      "paperValueChange": {
        "phasedRegistrationNames": {
          "captured": "onValueChangeCapture",
          "bubbled": "onValueChange"
        }
      },
      "topValueChange": {
        "phasedRegistrationNames": {
          "captured": "onValueChangeCapture",
          "bubbled": "onValueChange"
        }
      }
    },
    "directEventTypes": {
      "paperSlidingComplete": {
        "registrationName": "onSlidingComplete"
      }
    },
    "validAttributes": {
      "disabled": true,
      "maximumTrackImage": {
        "process": "[Function resolveAssetSource]"
      },
      "minimumTrackImage": {
        "process": "[Function resolveAssetSource]"
      },
      "thumbImage": {
        "process": "[Function resolveAssetSource]"
      },
      "trackImage": {
        "process": "[Function resolveAssetSource]"
      }
    }
  },
  "unequal": {}
}
```

## iOS Failures
```
 LOG  SVC RCTSlider Invalid
 LOG  {
  "missing": {},
  "unexpected": {
    "bubblingEventTypes": {
      "paperValueChange": {
        "phasedRegistrationNames": {
          "captured": "onValueChangeCapture",
          "bubbled": "onValueChange"
        }
      }
    },
    "directEventTypes": {
      "paperSlidingComplete": {
        "registrationName": "onSlidingComplete"
      }
    },
    "validAttributes": {
      "enabled": true
    }
  },
  "unequal": []
}
```

Reviewed By: yungsters

Differential Revision: D33409401

fbshipit-source-id: 519b6e35246e6671dbea1f374435d92937d96c1d
This commit is contained in:
Ramanpreet Nara
2022-01-14 16:31:50 -08:00
committed by Facebook GitHub Bot
parent 4ac209ca1d
commit 28f5abc717
4 changed files with 29 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/views/slider/ReactSliderManager.java
+24
View File
@@ -221,12 +221,15 @@ public class ReactSliderManager extends SimpleViewManager<ReactSlider>
}
@Override
@ReactProp(name = "disabled")
public void setDisabled(ReactSlider view, boolean value) {}
@Override
@ReactProp(name = "maximumTrackImage", customType = "ImageSource")
public void setMaximumTrackImage(ReactSlider view, @Nullable ReadableMap value) {}
@Override
@ReactProp(name = "minimumTrackImage", customType = "ImageSource")
public void setMinimumTrackImage(ReactSlider view, @Nullable ReadableMap value) {}
@Override
@@ -235,9 +238,11 @@ public class ReactSliderManager extends SimpleViewManager<ReactSlider>
}
@Override
@ReactProp(name = "thumbImage", customType = "ImageSource")
public void setThumbImage(ReactSlider view, @Nullable ReadableMap value) {}
@Override
@ReactProp(name = "trackImage", customType = "ImageSource")
public void setTrackImage(ReactSlider view, @Nullable ReadableMap value) {}
@Override
@@ -258,6 +263,25 @@ public class ReactSliderManager extends SimpleViewManager<ReactSlider>
return eventTypeConstants;
}
@Nullable
@Override
public Map<String, Object> getExportedCustomBubblingEventTypeConstants() {
@Nullable
Map<String, Object> baseEventTypeConstants =
super.getExportedCustomBubblingEventTypeConstants();
Map<String, Object> eventTypeConstants =
baseEventTypeConstants == null ? new HashMap<String, Object>() : baseEventTypeConstants;
eventTypeConstants.putAll(
MapBuilder.<String, Object>builder()
.put(
"topValueChange",
MapBuilder.of(
"phasedRegistrationNames",
MapBuilder.of("bubbled", "onValueChange", "captured", "onValueChangeCapture")))
.build());
return eventTypeConstants;
}
@Override
public long measure(
Context context,