mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
fix(iOS): allow to interactively swipe down the modal (#51483)
Summary: This PR allows to interactively close the modal using the swipe down gesture. It fixes 5 year old issue: https://github.com/facebook/react-native/issues/29319 In short it removes `modalInPresentation` which according to the documentation causes: "UIKit ignores events outside the view controller’s bounds and **prevents the interactive dismissal of the view controller while it is onscreen.**". It also adds another delegate event to call onRequestClose whenever modal is closed by gesture. https://github.com/user-attachments/assets/8849ecba-f762-47ec-a28b-b41c1991a882 ## Changelog: [IOS] [ADDED] - Allow to interactively swipe down the modal. Add allowSwipeDismissal prop. Pull Request resolved: https://github.com/facebook/react-native/pull/51483 Test Plan: Test if swiping down the modal calls onRequestClose Reviewed By: rshest Differential Revision: D75125438 Pulled By: javache fbshipit-source-id: d4f2c8b59447680f405b725d0809573a937f97cf
This commit is contained in:
1 parent
ce75271d47
commit
28986a7599
13 files changed
+90
-8
No files matched your search
@@ -5306,6 +5306,7 @@ public class com/facebook/react/viewmanagers/ModalHostViewManagerDelegate : com/
|
||||
}
|
||||
|
||||
public abstract interface class com/facebook/react/viewmanagers/ModalHostViewManagerInterface : com/facebook/react/uimanager/ViewManagerWithGeneratedInterface {
|
||||
public abstract fun setAllowSwipeDismissal (Landroid/view/View;Z)V
|
||||
public abstract fun setAnimated (Landroid/view/View;Z)V
|
||||
public abstract fun setAnimationType (Landroid/view/View;Ljava/lang/String;)V
|
||||
public abstract fun setHardwareAccelerated (Landroid/view/View;Z)V
|
||||
|
||||
Reference in new issue
Block a user