From 287cf070cb1c072bd5fdacc0b1ee3ae85c7a388e Mon Sep 17 00:00:00 2001 From: Betty Ni Date: Tue, 25 Aug 2020 12:20:39 -0700 Subject: [PATCH] Unbreak the build Summary: build-break overriding_review_checks_triggers_an_audit_and_retroactive_review Oncall Short Name: fbandroid_sheriff Differential Revision: D23325277 fbshipit-source-id: 20e4fb649ce8a0c8640a5ff1c5eb0ff310a4cc22 --- .../specs/NativeAccessibilityManagerSpec.java | 4 ++-- .../specs/NativeAnimatedModuleSpec.java | 20 +++++++++---------- .../specs/NativeAnimatedTurboModuleSpec.java | 20 +++++++++---------- .../fbreact/specs/NativeAppearanceSpec.java | 6 +++--- .../fbreact/specs/NativeAsyncStorageSpec.java | 8 ++++---- .../fbreact/specs/NativeBlobModuleSpec.java | 4 ++-- .../fbreact/specs/NativeDevSettingsSpec.java | 12 +++++------ .../specs/NativeExceptionsManagerSpec.java | 4 ++-- .../specs/NativeImageLoaderAndroidSpec.java | 4 ++-- .../specs/NativeImagePickerIOSSpec.java | 6 +++--- .../fbreact/specs/NativeLinkingSpec.java | 4 ++-- .../specs/NativePermissionsAndroidSpec.java | 4 ++-- .../NativePushNotificationManagerIOSSpec.java | 20 +++++++++---------- .../fbreact/specs/NativeToastAndroidSpec.java | 6 +++--- .../fbreact/specs/NativeUIManagerSpec.java | 20 +++++++++---------- .../specs/NativeWebSocketModuleSpec.java | 4 ++-- 16 files changed, 73 insertions(+), 73 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAccessibilityManagerSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAccessibilityManagerSpec.java index a25747864a6..85eca1d044f 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAccessibilityManagerSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAccessibilityManagerSpec.java @@ -32,13 +32,13 @@ public abstract class NativeAccessibilityManagerSpec extends ReactContextBaseJav public abstract void getCurrentReduceTransparencyState(Callback onSuccess, Callback onError); @ReactMethod - public abstract void getCurrentInvertColorsState(Callback onSuccess, Callback onError); + public abstract void getCurrentBoldTextState(Callback onSuccess, Callback onError); @ReactMethod public abstract void getCurrentGrayscaleState(Callback onSuccess, Callback onError); @ReactMethod - public abstract void getCurrentBoldTextState(Callback onSuccess, Callback onError); + public abstract void getCurrentInvertColorsState(Callback onSuccess, Callback onError); @ReactMethod public abstract void setAccessibilityFocus(double reactTag); diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAnimatedModuleSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAnimatedModuleSpec.java index 109fe5e29cd..84de5093cdb 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAnimatedModuleSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAnimatedModuleSpec.java @@ -26,33 +26,33 @@ public abstract class NativeAnimatedModuleSpec extends ReactContextBaseJavaModul } @ReactMethod - public abstract void dropAnimatedNode(double tag); + public abstract void connectAnimatedNodes(double parentTag, double childTag); @ReactMethod - public abstract void connectAnimatedNodes(double parentTag, double childTag); + public abstract void dropAnimatedNode(double tag); @ReactMethod public abstract void stopAnimation(double animationId); + @ReactMethod + public abstract void disconnectAnimatedNodeFromView(double nodeTag, double viewTag); + @ReactMethod public abstract void removeListeners(double count); @ReactMethod - public abstract void disconnectAnimatedNodeFromView(double nodeTag, double viewTag); + public abstract void flattenAnimatedNodeOffset(double nodeTag); @ReactMethod public abstract void removeAnimatedEventFromView(double viewTag, String eventName, double animatedNodeTag); @ReactMethod - public abstract void flattenAnimatedNodeOffset(double nodeTag); + public abstract void disconnectAnimatedNodes(double parentTag, double childTag); @ReactMethod public abstract void extractAnimatedNodeOffset(double nodeTag); - @ReactMethod - public abstract void disconnectAnimatedNodes(double parentTag, double childTag); - @ReactMethod public abstract void setAnimatedNodeValue(double nodeTag, double value); @@ -62,13 +62,13 @@ public abstract class NativeAnimatedModuleSpec extends ReactContextBaseJavaModul @ReactMethod public abstract void setAnimatedNodeOffset(double nodeTag, double offset); - @ReactMethod - public abstract void restoreDefaultValues(double nodeTag); - @ReactMethod public abstract void startAnimatingNode(double animationId, double nodeTag, ReadableMap config, Callback endCallback); + @ReactMethod + public abstract void restoreDefaultValues(double nodeTag); + @ReactMethod public abstract void getValue(double tag, Callback saveValueCallback); diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAnimatedTurboModuleSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAnimatedTurboModuleSpec.java index 27c614e9a3d..64f09cae2c2 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAnimatedTurboModuleSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAnimatedTurboModuleSpec.java @@ -26,33 +26,33 @@ public abstract class NativeAnimatedTurboModuleSpec extends ReactContextBaseJava } @ReactMethod - public abstract void dropAnimatedNode(double tag); + public abstract void connectAnimatedNodes(double parentTag, double childTag); @ReactMethod - public abstract void connectAnimatedNodes(double parentTag, double childTag); + public abstract void dropAnimatedNode(double tag); @ReactMethod public abstract void stopAnimation(double animationId); + @ReactMethod + public abstract void disconnectAnimatedNodeFromView(double nodeTag, double viewTag); + @ReactMethod public abstract void removeListeners(double count); @ReactMethod - public abstract void disconnectAnimatedNodeFromView(double nodeTag, double viewTag); + public abstract void flattenAnimatedNodeOffset(double nodeTag); @ReactMethod public abstract void removeAnimatedEventFromView(double viewTag, String eventName, double animatedNodeTag); @ReactMethod - public abstract void flattenAnimatedNodeOffset(double nodeTag); + public abstract void disconnectAnimatedNodes(double parentTag, double childTag); @ReactMethod public abstract void extractAnimatedNodeOffset(double nodeTag); - @ReactMethod - public abstract void disconnectAnimatedNodes(double parentTag, double childTag); - @ReactMethod public abstract void setAnimatedNodeValue(double nodeTag, double value); @@ -62,13 +62,13 @@ public abstract class NativeAnimatedTurboModuleSpec extends ReactContextBaseJava @ReactMethod public abstract void setAnimatedNodeOffset(double nodeTag, double offset); - @ReactMethod - public abstract void restoreDefaultValues(double nodeTag); - @ReactMethod public abstract void startAnimatingNode(double animationId, double nodeTag, ReadableMap config, Callback endCallback); + @ReactMethod + public abstract void restoreDefaultValues(double nodeTag); + @ReactMethod public abstract void getValue(double tag, Callback saveValueCallback); diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAppearanceSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAppearanceSpec.java index d374986b1f5..f3062e88c70 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAppearanceSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAppearanceSpec.java @@ -27,11 +27,11 @@ public abstract class NativeAppearanceSpec extends ReactContextBaseJavaModule im @ReactMethod public abstract void removeListeners(double count); - @ReactMethod - public abstract void addListener(String eventName); - @ReactMethod( isBlockingSynchronousMethod = true ) public abstract @Nullable String getColorScheme(); + + @ReactMethod + public abstract void addListener(String eventName); } diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAsyncStorageSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAsyncStorageSpec.java index 562e308978d..336a1721c42 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAsyncStorageSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeAsyncStorageSpec.java @@ -28,18 +28,18 @@ public abstract class NativeAsyncStorageSpec extends ReactContextBaseJavaModule @ReactMethod public abstract void multiSet(ReadableArray kvPairs, Callback callback); - @ReactMethod - public abstract void getAllKeys(Callback callback); - @ReactMethod public abstract void multiGet(ReadableArray keys, Callback callback); @ReactMethod - public abstract void clear(Callback callback); + public abstract void getAllKeys(Callback callback); @ReactMethod public abstract void multiMerge(ReadableArray kvPairs, Callback callback); + @ReactMethod + public abstract void clear(Callback callback); + @ReactMethod public abstract void multiRemove(ReadableArray keys, Callback callback); } diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeBlobModuleSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeBlobModuleSpec.java index 774bbfd390a..79afe32db09 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeBlobModuleSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeBlobModuleSpec.java @@ -38,10 +38,10 @@ public abstract class NativeBlobModuleSpec extends ReactContextBaseJavaModule im public abstract void addNetworkingHandler(); @ReactMethod - public abstract void createFromParts(ReadableArray parts, String withId); + public abstract void addWebSocketHandler(double id); @ReactMethod - public abstract void addWebSocketHandler(double id); + public abstract void createFromParts(ReadableArray parts, String withId); @ReactMethod public abstract void release(String blobId); diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeDevSettingsSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeDevSettingsSpec.java index 77bd1cdf8de..3405f97b2f1 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeDevSettingsSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeDevSettingsSpec.java @@ -31,10 +31,10 @@ public abstract class NativeDevSettingsSpec extends ReactContextBaseJavaModule i } @ReactMethod - public abstract void removeListeners(double count); + public abstract void reload(); @ReactMethod - public abstract void reload(); + public abstract void removeListeners(double count); @ReactMethod public abstract void setProfilingEnabled(boolean isProfilingEnabled); @@ -43,18 +43,18 @@ public abstract class NativeDevSettingsSpec extends ReactContextBaseJavaModule i public abstract void addMenuItem(String title); @ReactMethod - public abstract void toggleElementInspector(); + public abstract void setHotLoadingEnabled(boolean isHotLoadingEnabled); @ReactMethod - public abstract void setHotLoadingEnabled(boolean isHotLoadingEnabled); + public abstract void toggleElementInspector(); @ReactMethod public void reloadWithReason(String reason) { } @ReactMethod - public abstract void setIsShakeToShowDevMenuEnabled(boolean enabled); + public abstract void addListener(String eventName); @ReactMethod - public abstract void addListener(String eventName); + public abstract void setIsShakeToShowDevMenuEnabled(boolean enabled); } diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeExceptionsManagerSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeExceptionsManagerSpec.java index 0e55067f682..e532a1ad0dd 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeExceptionsManagerSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeExceptionsManagerSpec.java @@ -30,7 +30,7 @@ public abstract class NativeExceptionsManagerSpec extends ReactContextBaseJavaMo } @ReactMethod - public abstract void updateExceptionMessage(String message, ReadableArray stack, + public abstract void reportFatalException(String message, ReadableArray stack, double exceptionId); @ReactMethod @@ -38,7 +38,7 @@ public abstract class NativeExceptionsManagerSpec extends ReactContextBaseJavaMo } @ReactMethod - public abstract void reportFatalException(String message, ReadableArray stack, + public abstract void updateExceptionMessage(String message, ReadableArray stack, double exceptionId); @ReactMethod diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeImageLoaderAndroidSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeImageLoaderAndroidSpec.java index dd045e96e64..c45d320f351 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeImageLoaderAndroidSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeImageLoaderAndroidSpec.java @@ -27,10 +27,10 @@ public abstract class NativeImageLoaderAndroidSpec extends ReactContextBaseJavaM } @ReactMethod - public abstract void getSize(String uri, Promise promise); + public abstract void abortRequest(double requestId); @ReactMethod - public abstract void abortRequest(double requestId); + public abstract void getSize(String uri, Promise promise); @ReactMethod public abstract void prefetchImage(String uri, double requestId, Promise promise); diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeImagePickerIOSSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeImagePickerIOSSpec.java index 4c0ac13fa0d..b49706aab7e 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeImagePickerIOSSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeImagePickerIOSSpec.java @@ -30,11 +30,11 @@ public abstract class NativeImagePickerIOSSpec extends ReactContextBaseJavaModul Callback cancelCallback); @ReactMethod - public abstract void openSelectDialog(ReadableMap config, Callback successCallback, - Callback cancelCallback); + public abstract void canUseCamera(Callback callback); @ReactMethod - public abstract void canUseCamera(Callback callback); + public abstract void openSelectDialog(ReadableMap config, Callback successCallback, + Callback cancelCallback); @ReactMethod public abstract void canRecordVideos(Callback callback); diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeLinkingSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeLinkingSpec.java index fda26bec4a8..de6e7143dd2 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeLinkingSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeLinkingSpec.java @@ -26,10 +26,10 @@ public abstract class NativeLinkingSpec extends ReactContextBaseJavaModule imple } @ReactMethod - public abstract void sendIntent(String action, ReadableArray extras, Promise promise); + public abstract void openURL(String url, Promise promise); @ReactMethod - public abstract void openURL(String url, Promise promise); + public abstract void sendIntent(String action, ReadableArray extras, Promise promise); @ReactMethod public abstract void removeListeners(double count); diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativePermissionsAndroidSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativePermissionsAndroidSpec.java index 0c9f8adec51..7a9bb302562 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativePermissionsAndroidSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativePermissionsAndroidSpec.java @@ -26,10 +26,10 @@ public abstract class NativePermissionsAndroidSpec extends ReactContextBaseJavaM } @ReactMethod - public abstract void requestPermission(String permission, Promise promise); + public abstract void checkPermission(String permission, Promise promise); @ReactMethod - public abstract void checkPermission(String permission, Promise promise); + public abstract void requestPermission(String permission, Promise promise); @ReactMethod public abstract void shouldShowRequestPermissionRationale(String permission, Promise promise); diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativePushNotificationManagerIOSSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativePushNotificationManagerIOSSpec.java index a2b10ddcc25..30d38661fd0 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativePushNotificationManagerIOSSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativePushNotificationManagerIOSSpec.java @@ -28,10 +28,10 @@ public abstract class NativePushNotificationManagerIOSSpec extends ReactContextB } @ReactMethod - public abstract void removeListeners(double count); + public abstract void getInitialNotification(Promise promise); @ReactMethod - public abstract void getInitialNotification(Promise promise); + public abstract void removeListeners(double count); @ReactMethod public abstract void setApplicationIconBadgeNumber(double num); @@ -40,13 +40,13 @@ public abstract class NativePushNotificationManagerIOSSpec extends ReactContextB public abstract void scheduleLocalNotification(ReadableMap notification); @ReactMethod - public abstract void getScheduledLocalNotifications(Callback callback); + public abstract void requestPermissions(ReadableMap permission, Promise promise); @ReactMethod public abstract void checkPermissions(Callback callback); @ReactMethod - public abstract void requestPermissions(ReadableMap permission, Promise promise); + public abstract void getScheduledLocalNotifications(Callback callback); @ReactMethod public abstract void removeAllDeliveredNotifications(); @@ -54,18 +54,18 @@ public abstract class NativePushNotificationManagerIOSSpec extends ReactContextB @ReactMethod public abstract void onFinishRemoteNotification(String notificationId, String fetchResult); - @ReactMethod - public abstract void cancelLocalNotifications(ReadableMap userInfo); - @ReactMethod public abstract void abandonPermissions(); @ReactMethod - public abstract void removeDeliveredNotifications(ReadableArray identifiers); + public abstract void cancelLocalNotifications(ReadableMap userInfo); @ReactMethod public abstract void cancelAllLocalNotifications(); + @ReactMethod + public abstract void removeDeliveredNotifications(ReadableArray identifiers); + @ReactMethod public abstract void getDeliveredNotifications(Callback callback); @@ -73,8 +73,8 @@ public abstract class NativePushNotificationManagerIOSSpec extends ReactContextB public abstract void getApplicationIconBadgeNumber(Callback callback); @ReactMethod - public abstract void addListener(String eventType); + public abstract void presentLocalNotification(ReadableMap notification); @ReactMethod - public abstract void presentLocalNotification(ReadableMap notification); + public abstract void addListener(String eventType); } diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeToastAndroidSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeToastAndroidSpec.java index d9bf4efc8c2..058f5f4806e 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeToastAndroidSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeToastAndroidSpec.java @@ -30,11 +30,11 @@ public abstract class NativeToastAndroidSpec extends ReactContextBaseJavaModule } @ReactMethod - public abstract void showWithGravityAndOffset(String message, double duration, double gravity, - double xOffset, double yOffset); + public abstract void show(String message, double duration); @ReactMethod - public abstract void show(String message, double duration); + public abstract void showWithGravityAndOffset(String message, double duration, double gravity, + double xOffset, double yOffset); @ReactMethod public abstract void showWithGravity(String message, double duration, double gravity); diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeUIManagerSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeUIManagerSpec.java index 03e3fe9bb0c..9f7f8697760 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeUIManagerSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeUIManagerSpec.java @@ -43,10 +43,10 @@ public abstract class NativeUIManagerSpec extends ReactContextBaseJavaModule imp Callback errorCallback); @ReactMethod - public abstract void blur(Double reactTag); + public abstract void focus(Double reactTag); @ReactMethod - public abstract void focus(Double reactTag); + public abstract void blur(Double reactTag); @ReactMethod public abstract void removeSubviewsFromContainerWithID(double containerID); @@ -54,13 +54,13 @@ public abstract class NativeUIManagerSpec extends ReactContextBaseJavaModule imp @ReactMethod public abstract void setJSResponder(Double reactTag, boolean blockNativeResponder); - @ReactMethod - public abstract void clearJSResponder(); - @ReactMethod public abstract void measureLayout(Double reactTag, Double ancestorReactTag, Callback errorCallback, Callback callback); + @ReactMethod + public abstract void clearJSResponder(); + @ReactMethod( isBlockingSynchronousMethod = true ) @@ -77,21 +77,21 @@ public abstract class NativeUIManagerSpec extends ReactContextBaseJavaModule imp public abstract void createView(Double reactTag, String viewName, double rootTag, ReadableMap props); - @ReactMethod - public abstract void sendAccessibilityEvent(Double reactTag, double eventType); - @ReactMethod public abstract void measureInWindow(Double reactTag, Callback callback); @ReactMethod - public abstract void viewIsDescendantOf(Double reactTag, Double ancestorReactTag, - Callback callback); + public abstract void sendAccessibilityEvent(Double reactTag, double eventType); @ReactMethod( isBlockingSynchronousMethod = true ) public abstract WritableMap lazilyLoadView(String name); + @ReactMethod + public abstract void viewIsDescendantOf(Double reactTag, Double ancestorReactTag, + Callback callback); + @ReactMethod public abstract void findSubviewIn(Double reactTag, ReadableArray point, Callback callback); diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeWebSocketModuleSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeWebSocketModuleSpec.java index 6eeddd2fe00..765bdd925de 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeWebSocketModuleSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeWebSocketModuleSpec.java @@ -35,10 +35,10 @@ public abstract class NativeWebSocketModuleSpec extends ReactContextBaseJavaModu public abstract void ping(double socketID); @ReactMethod - public abstract void close(double code, String reason, double socketID); + public abstract void send(String message, double forSocketID); @ReactMethod - public abstract void send(String message, double forSocketID); + public abstract void close(double code, String reason, double socketID); @ReactMethod public abstract void connect(String url, ReadableArray protocols, ReadableMap options,