From 27b7512d85a0d0d6445d8620343ea171cde4ea05 Mon Sep 17 00:00:00 2001 From: Joe Vilches Date: Wed, 26 Mar 2025 21:45:27 -0700 Subject: [PATCH] Back out "Finish adding accessibilityOrder to ReactNative" Summary: This isn't ready yet, we shouldn't expose it. Original commit changeset: 110ba4c42adc Original Phabricator Diff: D71420768 Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D71938547 fbshipit-source-id: 5026dcc11c151ad16386c1f11a702b46308a0e51 --- .../Libraries/Components/View/ViewAccessibility.js | 5 ----- .../__tests__/__snapshots__/public-api-test.js.snap | 1 - .../renderer/components/view/HostPlatformViewProps.cpp | 8 -------- 3 files changed, 14 deletions(-) diff --git a/packages/react-native/Libraries/Components/View/ViewAccessibility.js b/packages/react-native/Libraries/Components/View/ViewAccessibility.js index 1714fc1f621..e7cc4658608 100644 --- a/packages/react-native/Libraries/Components/View/ViewAccessibility.js +++ b/packages/react-native/Libraries/Components/View/ViewAccessibility.js @@ -325,11 +325,6 @@ export type AccessibilityPropsIOS = $ReadOnly<{ export type AccessibilityProps = $ReadOnly<{ ...AccessibilityPropsAndroid, ...AccessibilityPropsIOS, - /** - * Array which specifies the order in which the children of a view will be focused by the accessibility service. - */ - accessibilityOrder?: $ReadOnlyArray, - /** * When `true`, indicates that the view is an accessibility element. * By default, all the touchable elements are accessible. diff --git a/packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap b/packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap index fcd804753d0..ab6bf2d5924 100644 --- a/packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap +++ b/packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap @@ -3947,7 +3947,6 @@ export type AccessibilityPropsIOS = $ReadOnly<{ export type AccessibilityProps = $ReadOnly<{ ...AccessibilityPropsAndroid, ...AccessibilityPropsIOS, - accessibilityOrder?: $ReadOnlyArray, accessible?: ?boolean, accessibilityLabel?: ?Stringish, accessibilityHint?: ?Stringish, diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/HostPlatformViewProps.cpp b/packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/HostPlatformViewProps.cpp index 8e9981116e3..4355fed6c45 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/HostPlatformViewProps.cpp +++ b/packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/HostPlatformViewProps.cpp @@ -823,14 +823,6 @@ folly::dynamic HostPlatformViewProps::getDiffProps( result["accessibilityLabelledBy"] = accessibilityLabelledByValues; } - if (accessibilityOrder != oldProps->accessibilityOrder) { - auto accessibilityChildrenIds = folly::dynamic::array(); - for (const auto& accessibilityChildId : accessibilityOrder) { - accessibilityChildrenIds.push_back(accessibilityChildId); - } - result["accessibilityElements"] = accessibilityChildrenIds; - } - if (accessibilityLiveRegion != oldProps->accessibilityLiveRegion) { switch (accessibilityLiveRegion) { case AccessibilityLiveRegion::Assertive: