diff --git a/.github/actions/cache_setup/action.yml b/.github/actions/cache-setup/action.yml similarity index 99% rename from .github/actions/cache_setup/action.yml rename to .github/actions/cache-setup/action.yml index e8813743283..5914810dbe5 100644 --- a/.github/actions/cache_setup/action.yml +++ b/.github/actions/cache-setup/action.yml @@ -1,4 +1,4 @@ -name: cache_setup +name: cache-setup description: "Cache setup" inputs: hermes-version: diff --git a/.github/actions/create-release/action.yml b/.github/actions/create-release/action.yml index fb52223504f..3eb64088a07 100644 --- a/.github/actions/create-release/action.yml +++ b/.github/actions/create-release/action.yml @@ -2,14 +2,14 @@ name: create_release description: Creates a new React Native release inputs: version: - description: 'The version of React Native we want to release. For example 0.75.0-rc.0' + description: "The version of React Native we want to release. For example 0.75.0-rc.0" required: true - is_latest_on_npm: - description: 'Whether we want to tag this release as latest on NPM' + is-latest-on-npm: + description: "Whether we want to tag this release as latest on NPM" required: true default: "false" - dry_run: - description: 'Whether the job should be executed in dry-run mode or not' + dry-run: + description: "Whether the job should be executed in dry-run mode or not" default: "true" runs: using: composite @@ -27,8 +27,8 @@ runs: run: | node scripts/releases/create-release-commit.js \ --reactNativeVersion "${{ inputs.version }}" \ - --tagAsLatestRelease "${{ inputs.is_latest_on_npm }}" \ - --dryRun "${{ inputs.dry_run }}" + --tagAsLatestRelease "${{ inputs.is-latest-on-npm }}" \ + --dryRun "${{ inputs.dry-run }}" GIT_PAGER=cat git show HEAD - name: Update "latest" tag if needed shell: bash @@ -39,7 +39,7 @@ runs: git tag -a "latest" -m "latest" - name: Pushing release commit shell: bash - if: ${{ inputs.dry_run == 'false' }} + if: ${{ inputs.dry-run == 'false' }} run: | CURR_BRANCH="$(git branch --show-current)" git push origin "$CURR_BRANCH" --follow-tags diff --git a/.github/actions/prepare_ios_tests/action.yml b/.github/actions/prepare-ios-tests/action.yml similarity index 96% rename from .github/actions/prepare_ios_tests/action.yml rename to .github/actions/prepare-ios-tests/action.yml index 629ef73263b..daa43b3b64e 100644 --- a/.github/actions/prepare_ios_tests/action.yml +++ b/.github/actions/prepare-ios-tests/action.yml @@ -1,4 +1,4 @@ -name: prepare_ios_tests +name: prepare-ios-tests description: Prepare iOS Tests runs: using: composite diff --git a/.github/actions/report_bundle_size/action.yml b/.github/actions/report-bundle-size/action.yml similarity index 93% rename from .github/actions/report_bundle_size/action.yml rename to .github/actions/report-bundle-size/action.yml index 22ca863f54d..c74fec1723d 100644 --- a/.github/actions/report_bundle_size/action.yml +++ b/.github/actions/report-bundle-size/action.yml @@ -1,4 +1,4 @@ -name: report_bundle_size +name: report-bundle-size description: Report bundle size inputs: platform: diff --git a/.github/actions/run_e2e/action.yml b/.github/actions/run_e2e/action.yml deleted file mode 100644 index f90a98b9764..00000000000 --- a/.github/actions/run_e2e/action.yml +++ /dev/null @@ -1,19 +0,0 @@ -name: run_e2e -description: "Run End-to-End Tests" -inputs: - platform: - description: "Platform to run tests on" - required: true - default: "js" - retries: - description: "Number of times to retry failed tests" - required: true - default: "3" -runs: - using: composite - steps: - - name: "Run Tests: ${{ inputs.platform }} End-to-End Tests" - # Disabled to remove the template from react-native - if: false - run: node ./scripts/e2e/run-ci-e2e-tests.js --${{ inputs.platform }} --retries ${{ inputs.retries }} - shell: bash diff --git a/.github/actions/setup_xcode_build_cache/action.yml b/.github/actions/setup-xcode-build-cache/action.yml similarity index 97% rename from .github/actions/setup_xcode_build_cache/action.yml rename to .github/actions/setup-xcode-build-cache/action.yml index d00ab3b9d4c..0ce1bc5aaaa 100644 --- a/.github/actions/setup_xcode_build_cache/action.yml +++ b/.github/actions/setup-xcode-build-cache/action.yml @@ -1,4 +1,4 @@ -name: setup_xcode_build_cache +name: setup-xcode-build-cache description: Add caching to iOS jobs to speed up builds inputs: hermes-version: diff --git a/.github/actions/test_ios_helloworld/action.yml b/.github/actions/test-ios-helloworld/action.yml similarity index 88% rename from .github/actions/test_ios_helloworld/action.yml rename to .github/actions/test-ios-helloworld/action.yml index 5df716c6a74..2e147236f13 100644 --- a/.github/actions/test_ios_helloworld/action.yml +++ b/.github/actions/test-ios-helloworld/action.yml @@ -1,37 +1,21 @@ -name: test_ios_helloworld +name: test-ios-helloworld description: Test iOS Hello World inputs: jsengine: description: Which JavaScript engine to use. Must be one of "Hermes", "JSC". - type: choice default: Hermes - options: - - JSC - - Hermes use-frameworks: - description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "DynamicFrameworks" - type: choice - default: StaticLibraries - options: - - StaticLibraries - - DynamicFrameworks + description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "DynamicFrameworks" + default: StaticLibraries architecture: - description: The React Native architecture to Test. RNTester has always Fabric enabled, but we want to run integration test with the old arch setup - type: choice + description: The React Native architecture to Test. RNTester has always Fabric enabled, but we want to run integration test with the old arch setup. Must be one of "OldArch" or "NewArch" default: OldArch - options: - - OldArch - - NewArch ruby-version: description: The version of ruby that must be used default: 2.6.10 flavor: description: The flavor of the build. Must be one of "Debug", "Release". - type: choice default: Debug - options: - - Debug - - Release hermes-version: description: The version of hermes required: true diff --git a/.github/actions/test_ios_rntester/action.yml b/.github/actions/test-ios-rntester/action.yml similarity index 93% rename from .github/actions/test_ios_rntester/action.yml rename to .github/actions/test-ios-rntester/action.yml index bf318176f84..c18981d4520 100644 --- a/.github/actions/test_ios_rntester/action.yml +++ b/.github/actions/test-ios-rntester/action.yml @@ -1,12 +1,12 @@ -name: test_ios_rntester +name: test-ios-rntester description: Test iOS RNTester inputs: jsengine: description: Which JavaScript engine to use. Must be one of "Hermes", "JSC". default: Hermes use-frameworks: - description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "DynamicFrameworks" - default: StaticLibraries + description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "DynamicFrameworks" + default: StaticLibraries architecture: description: The React Native architecture to Test. RNTester has always Fabric enabled, but we want to run integration test with the old arch setup default: NewArch @@ -15,7 +15,7 @@ inputs: default: 2.6.10 run-unit-tests: description: whether unit tests should run or not. - default: false + default: "false" hermes-tarball-artifacts-dir: description: The directory where the hermes tarball artifacts are stored default: /tmp/hermes/hermes-runtime-darwin @@ -49,7 +49,7 @@ runs: ruby-version: ${{ inputs.ruby-version }} - name: Prepare IOS Tests if: ${{ inputs.run-unit-tests == 'true' }} - uses: ./.github/actions/prepare_ios_tests + uses: ./.github/actions/prepare-ios-tests - name: Set HERMES_ENGINE_TARBALL_PATH envvar if Hermes tarball is present shell: bash run: | @@ -89,7 +89,7 @@ runs: echo 'No Hermes tarball found.' fi - name: Setup xcode build cache - uses: ./.github/actions/setup_xcode_build_cache + uses: ./.github/actions/setup-xcode-build-cache with: hermes-version: ${{ inputs.hermes-version }} - name: Install CocoaPods dependencies @@ -141,7 +141,7 @@ runs: path: /Users/distiller/Library/Developer/Xcode/xcresults.tar.gz - name: Report bundle size if: ${{ inputs.run-unit-tests == 'true' }} - uses: ./.github/actions/report_bundle_size + uses: ./.github/actions/report-bundle-size with: platform: ios - name: Store test results diff --git a/.github/workflows/create-release.yml b/.github/workflows/create-release.yml index 07e46d8a7a1..06b9a5608e5 100644 --- a/.github/workflows/create-release.yml +++ b/.github/workflows/create-release.yml @@ -4,16 +4,16 @@ on: workflow_dispatch: inputs: version: - description: 'The version of React Native we want to release. For example 0.75.0-rc.0' + description: "The version of React Native we want to release. For example 0.75.0-rc.0" required: true type: string - is_latest_on_npm: - description: 'Whether we want to tag this release as latest on NPM' + is-latest-on-npm: + description: "Whether we want to tag this release as latest on NPM" required: true type: boolean default: false - dry_run: - description: 'Whether the job should be executed in dry-run mode or not' + dry-run: + description: "Whether the job should be executed in dry-run mode or not" type: boolean default: false @@ -49,6 +49,6 @@ jobs: if: ${{ steps.check_stable_branch.outputs.ON_STABLE_BRANCH && !steps.check_if_tag_exists.outputs.TAG_EXISTS }} uses: ./.github/actions/create-release with: - version: ${{ inputs.version }} - is_latest_on_npm: ${{ inputs.is_latest_on_npm }} - dry_run: ${{ inputs.dry_run }} + version: ${{ inputs.version }} + is-latest-on-npm: ${{ inputs.is-latest-on-npm }} + dry-run: ${{ inputs.dry-run }} diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index fdc1f6109a0..c6ae753085a 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -620,8 +620,8 @@ jobs: name: hermes-linux-bin path: /tmp/hermes/linux64-bin - name: Cache setup - id: cache_setup - uses: ./.github/actions/cache_setup + id: cache-setup + uses: ./.github/actions/cache-setup with: hermes-version: ${{ needs.prepare_hermes_workspace.outputs.hermes-version }} react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }} diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml index 409b3533882..1563a0cddd3 100644 --- a/.github/workflows/publish-release.yml +++ b/.github/workflows/publish-release.yml @@ -2,8 +2,8 @@ name: Publish Release on: push: tags: - - "v0.*.*" # This should match v0.X.Y - - "v0.*.*-rc.*" # This should match v0.X.Y-RC.0 + - "v0.*.*" # This should match v0.X.Y + - "v0.*.*-rc.*" # This should match v0.X.Y-RC.0 jobs: set_release_type: runs-on: ubuntu-latest @@ -553,12 +553,20 @@ jobs: build_npm_package: runs-on: 8-core-ubuntu - needs: [set_release_type, prepare_hermes_workspace, build_hermes_macos, build_hermesc_linux, build_hermesc_windows,build_android] + needs: + [ + set_release_type, + prepare_hermes_workspace, + build_hermes_macos, + build_hermesc_linux, + build_hermesc_windows, + build_android, + ] container: image: reactnativecommunity/react-native-android:latest env: TERM: "dumb" - GRADLE_OPTS: '-Dorg.gradle.daemon=false' + GRADLE_OPTS: "-Dorg.gradle.daemon=false" # By default we only build ARM64 to save time/resources. For release/nightlies/prealpha, we override this value to build all archs. ORG_GRADLE_PROJECT_reactNativeArchitectures: "arm64-v8a" HERMES_WS_DIR: /tmp/hermes @@ -617,8 +625,8 @@ jobs: name: hermes-linux-bin path: /tmp/hermes/linux64-bin - name: Cache setup - id: cache_setup - uses: ./.github/actions/cache_setup + id: cache-setup + uses: ./.github/actions/cache-setup with: hermes-version: ${{ needs.prepare_hermes_workspace.outputs.hermes-version }} react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }} diff --git a/.github/workflows/test-all.yml b/.github/workflows/test-all.yml index 7a67f4a89a2..e14632f2af9 100644 --- a/.github/workflows/test-all.yml +++ b/.github/workflows/test-all.yml @@ -383,7 +383,7 @@ jobs: - name: Checkout uses: actions/checkout@v4.1.1 - name: Run it - uses: ./.github/actions/test_ios_rntester + uses: ./.github/actions/test-ios-rntester with: ruby-version: "3.2.0" hermes-version: ${{ needs.prepare_hermes_workspace.outputs.hermes-version }} @@ -404,7 +404,7 @@ jobs: - name: Checkout uses: actions/checkout@v4.1.1 - name: Run it - uses: ./.github/actions/test_ios_rntester + uses: ./.github/actions/test-ios-rntester with: jsengine: ${{ matrix.jsengine }} use-frameworks: DynamicFrameworks @@ -428,7 +428,7 @@ jobs: - name: Checkout uses: actions/checkout@v4.1.1 - name: Run it - uses: ./.github/actions/test_ios_rntester + uses: ./.github/actions/test-ios-rntester with: jsengine: ${{ matrix.jsengine }} architecture: ${{ matrix.architecture }} @@ -824,8 +824,8 @@ jobs: - name: Setup git safe folders run: git config --global --add safe.directory '*' - name: Cache setup - id: cache_setup - uses: ./.github/actions/cache_setup + id: cache-setup + uses: ./.github/actions/cache-setup with: hermes-version: ${{ needs.prepare_hermes_workspace.outputs.hermes-version }} react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }} @@ -891,7 +891,7 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4.1.1 - - uses: ./.github/actions/test_ios_helloworld + - uses: ./.github/actions/test-ios-helloworld with: ruby-version: 3.2.0 architecture: NewArch @@ -919,7 +919,7 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4.1.1 - - uses: ./.github/actions/test_ios_helloworld + - uses: ./.github/actions/test-ios-helloworld with: flavor: ${{ matrix.flavor }} jsengine: ${{ matrix.jsengine }}