From 26d05d8dd782864437eeb0da0753bce59b2b8f35 Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Thu, 20 Jan 2022 13:23:51 -0800 Subject: [PATCH] Fix SVC for RCTModalHostView Summary: Making the native ViewConfig for RCTModalHostView match its static ViewConfig. Changelog: [Internal] Reviewed By: JoshuaGross Differential Revision: D33303419 fbshipit-source-id: 6fac237d670ee221ad867f79e54d5a3576c156da --- .../facebook/react/views/modal/ReactModalHostManager.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/modal/ReactModalHostManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/modal/ReactModalHostManager.java index 9a6e1c033c6..f078c599c7d 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/modal/ReactModalHostManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/modal/ReactModalHostManager.java @@ -99,15 +99,19 @@ public class ReactModalHostManager extends ViewGroupManager } @Override + @ReactProp(name = "presentationStyle") public void setPresentationStyle(ReactModalHostView view, @Nullable String value) {} @Override + @ReactProp(name = "animated") public void setAnimated(ReactModalHostView view, boolean value) {} @Override + @ReactProp(name = "supportedOrientations") public void setSupportedOrientations(ReactModalHostView view, @Nullable ReadableArray value) {} @Override + @ReactProp(name = "identifier") public void setIdentifier(ReactModalHostView view, int value) {} @Override @@ -146,6 +150,10 @@ public class ReactModalHostManager extends ViewGroupManager MapBuilder.builder() .put(RequestCloseEvent.EVENT_NAME, MapBuilder.of("registrationName", "onRequestClose")) .put(ShowEvent.EVENT_NAME, MapBuilder.of("registrationName", "onShow")) + // iOS only + .put("topDismiss", MapBuilder.of("registrationName", "onDismiss")) + // iOS only + .put("topOrientationChange", MapBuilder.of("registrationName", "onOrientationChange")) .build()); return eventTypeConstants; }