From 25c5539ee4be8cde5e7697db68a5edc9cffaebeb Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Mon, 7 Sep 2026 02:20:20 -0700 Subject: [PATCH] Cover react/renderer/attributedstring with Stable API guards (#58305) Summary: Pull Request resolved: https://github.com/react/react-native/pull/58305 Classifies `react/renderer/attributedstring:attributedstring` as a "for frameworks" target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get a warning if they include its headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. `React-Fabric` already depended on `React-cxxstableapi` from an earlier migration in the same pod, so the module's subspec needs no change. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D118619367 fbshipit-source-id: 711404c0388c49112c23a63a9ac96b080fc3fda8 --- .../react/renderer/attributedstring/AttributedString.h | 2 ++ .../react/renderer/attributedstring/AttributedStringBox.h | 2 ++ .../ReactCommon/react/renderer/attributedstring/CMakeLists.txt | 1 + .../react/renderer/attributedstring/ParagraphAttributes.h | 2 ++ .../renderer/attributedstring/PlaceholderAttributedString.h | 2 ++ .../react/renderer/attributedstring/TextAttributes.h | 2 ++ .../ReactCommon/react/renderer/attributedstring/conversions.h | 2 ++ .../ReactCommon/react/renderer/attributedstring/primitives.h | 2 ++ 8 files changed, 15 insertions(+) diff --git a/packages/react-native/ReactCommon/react/renderer/attributedstring/AttributedString.h b/packages/react-native/ReactCommon/react/renderer/attributedstring/AttributedString.h index 2a729d48378..f1cdbe4181c 100644 --- a/packages/react-native/ReactCommon/react/renderer/attributedstring/AttributedString.h +++ b/packages/react-native/ReactCommon/react/renderer/attributedstring/AttributedString.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/attributedstring/AttributedStringBox.h b/packages/react-native/ReactCommon/react/renderer/attributedstring/AttributedStringBox.h index f335dfde8af..4c9471bde5c 100644 --- a/packages/react-native/ReactCommon/react/renderer/attributedstring/AttributedStringBox.h +++ b/packages/react-native/ReactCommon/react/renderer/attributedstring/AttributedStringBox.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/attributedstring/CMakeLists.txt b/packages/react-native/ReactCommon/react/renderer/attributedstring/CMakeLists.txt index 47784a726f2..a337c84bf38 100644 --- a/packages/react-native/ReactCommon/react/renderer/attributedstring/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/renderer/attributedstring/CMakeLists.txt @@ -17,6 +17,7 @@ target_link_libraries(react_renderer_attributedstring folly_runtime glog glog_init + react_cxxstableapi react_debug rrc_view react_renderer_core diff --git a/packages/react-native/ReactCommon/react/renderer/attributedstring/ParagraphAttributes.h b/packages/react-native/ReactCommon/react/renderer/attributedstring/ParagraphAttributes.h index 367ec8c3e0d..b61457dbcf1 100644 --- a/packages/react-native/ReactCommon/react/renderer/attributedstring/ParagraphAttributes.h +++ b/packages/react-native/ReactCommon/react/renderer/attributedstring/ParagraphAttributes.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/attributedstring/PlaceholderAttributedString.h b/packages/react-native/ReactCommon/react/renderer/attributedstring/PlaceholderAttributedString.h index fdf10451752..d4b654f706b 100644 --- a/packages/react-native/ReactCommon/react/renderer/attributedstring/PlaceholderAttributedString.h +++ b/packages/react-native/ReactCommon/react/renderer/attributedstring/PlaceholderAttributedString.h @@ -7,6 +7,8 @@ #pragma once +#include + #include namespace facebook::react { diff --git a/packages/react-native/ReactCommon/react/renderer/attributedstring/TextAttributes.h b/packages/react-native/ReactCommon/react/renderer/attributedstring/TextAttributes.h index ffbbcf841cb..bcf902f9093 100644 --- a/packages/react-native/ReactCommon/react/renderer/attributedstring/TextAttributes.h +++ b/packages/react-native/ReactCommon/react/renderer/attributedstring/TextAttributes.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/attributedstring/conversions.h b/packages/react-native/ReactCommon/react/renderer/attributedstring/conversions.h index beed9673780..f2c1eeed4b3 100644 --- a/packages/react-native/ReactCommon/react/renderer/attributedstring/conversions.h +++ b/packages/react-native/ReactCommon/react/renderer/attributedstring/conversions.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/attributedstring/primitives.h b/packages/react-native/ReactCommon/react/renderer/attributedstring/primitives.h index 37ad9265edc..d9edc8de45a 100644 --- a/packages/react-native/ReactCommon/react/renderer/attributedstring/primitives.h +++ b/packages/react-native/ReactCommon/react/renderer/attributedstring/primitives.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include