From 251cbb3871888a04cf8c29594be60d70944e11f7 Mon Sep 17 00:00:00 2001 From: "Andrew Chen (Eng)" Date: Wed, 29 Aug 2018 09:49:59 -0700 Subject: [PATCH] Eagerly initialize FrescoModule Summary: It's unclear if this was a recent regression or not (too lazy to find out), but instrumentation tests are failing because FrescoModule is never initialized (see task for trace). Based on the initial introduction of this class (D2448321) it appears that FrescoModule was always intended to be initialized on startup. Let's eagerly init Fresco in that case. Reviewed By: fkgozali Differential Revision: D9556864 fbshipit-source-id: 0b670dec46f5087b3794330931ddf5d7782c8367 --- .../java/com/facebook/react/modules/fresco/FrescoModule.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/FrescoModule.java b/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/FrescoModule.java index 40e0a22eb0c..5e073cf27ab 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/FrescoModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/FrescoModule.java @@ -37,7 +37,7 @@ import okhttp3.OkHttpClient; * *

Does not expose any methods to JavaScript code. For initialization and cleanup only. */ -@ReactModule(name = "FrescoModule") +@ReactModule(name = "FrescoModule", needsEagerInit = true) public class FrescoModule extends ReactContextBaseJavaModule implements ModuleDataCleaner.Cleanable, LifecycleEventListener {