From 24e6722cb41d4168399e6c9ef5d26e54b722be61 Mon Sep 17 00:00:00 2001
From: Pieter De Baets <pieterdb@meta.com>
Date: Mon, 4 Mar 2024 03:53:42 -0800
Subject: [PATCH] Add TODOs for missing ReactActivityDelegate methods (#43294)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/43294

These are gated by `ReactFeatureFlags.enableBridgelessArchitecture` and are missing support. They should be evaluated for backwards compatibility

Changelog: [Internal]

Reviewed By: fkgozali

Differential Revision: D54422143

fbshipit-source-id: b35b60f17d68d412a354b20e02fb6bbf591c40b0
---
 .../facebook/react/ReactActivityDelegate.java | 20 ++++++++++++++-----
 .../com/facebook/react/ReactDelegate.java     |  1 -
 2 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivityDelegate.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivityDelegate.java
index 87ffae6ef54..4bbaa82e06f 100644
--- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivityDelegate.java
+++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivityDelegate.java
@@ -144,7 +144,9 @@ public class ReactActivityDelegate {
   }
 
   public boolean onKeyDown(int keyCode, KeyEvent event) {
-    if (!ReactFeatureFlags.enableBridgelessArchitecture) {
+    if (ReactFeatureFlags.enableBridgelessArchitecture) {
+      // TODO T156475655: support onKeyDown
+    } else {
       if (getReactNativeHost().hasInstance()
           && getReactNativeHost().getUseDeveloperSupport()
           && keyCode == KeyEvent.KEYCODE_MEDIA_FAST_FORWARD) {
@@ -160,7 +162,9 @@ public class ReactActivityDelegate {
   }
 
   public boolean onKeyLongPress(int keyCode, KeyEvent event) {
-    if (!ReactFeatureFlags.enableBridgelessArchitecture) {
+    if (ReactFeatureFlags.enableBridgelessArchitecture) {
+      // TODO T156475655: support onKeyLongPress
+    } else {
       if (getReactNativeHost().hasInstance()
           && getReactNativeHost().getUseDeveloperSupport()
           && keyCode == KeyEvent.KEYCODE_MEDIA_FAST_FORWARD) {
@@ -176,7 +180,9 @@ public class ReactActivityDelegate {
   }
 
   public boolean onNewIntent(Intent intent) {
-    if (!ReactFeatureFlags.enableBridgelessArchitecture) {
+    if (ReactFeatureFlags.enableBridgelessArchitecture) {
+      // TODO T156475655: support onNewIntent
+    } else {
       if (getReactNativeHost().hasInstance()) {
         getReactNativeHost().getReactInstanceManager().onNewIntent(intent);
         return true;
@@ -186,7 +192,9 @@ public class ReactActivityDelegate {
   }
 
   public void onWindowFocusChanged(boolean hasFocus) {
-    if (!ReactFeatureFlags.enableBridgelessArchitecture) {
+    if (ReactFeatureFlags.enableBridgelessArchitecture) {
+      // TODO T156475655: support onWindowFocusChanged
+    } else {
       if (getReactNativeHost().hasInstance()) {
         getReactNativeHost().getReactInstanceManager().onWindowFocusChange(hasFocus);
       }
@@ -194,7 +202,9 @@ public class ReactActivityDelegate {
   }
 
   public void onConfigurationChanged(Configuration newConfig) {
-    if (!ReactFeatureFlags.enableBridgelessArchitecture) {
+    if (ReactFeatureFlags.enableBridgelessArchitecture) {
+      // TODO T156475655: support onConfigurationChanged
+    } else {
       if (getReactNativeHost().hasInstance()) {
         getReactInstanceManager().onConfigurationChanged(getContext(), newConfig);
       }
diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactDelegate.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactDelegate.java
index 2140f4a0a1b..12b1b06b3fa 100644
--- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactDelegate.java
+++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactDelegate.java
@@ -140,7 +140,6 @@ public class ReactDelegate {
       int requestCode, int resultCode, Intent data, boolean shouldForwardToReactInstance) {
     if (ReactFeatureFlags.enableBridgelessArchitecture) {
       // TODO T156475655: Implement onActivityResult for Bridgeless
-      return;
     } else {
       if (getReactNativeHost().hasInstance() && shouldForwardToReactInstance) {
         getReactNativeHost()