From 2477fbc6005c4cbdc0ca3460413ce52e2e1e8bb5 Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Mon, 1 Apr 2024 19:50:33 -0700 Subject: [PATCH] Back out "fix: prevent error when react extension was already created" (#43753) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/43753 New build failures when this was merged seem likely related. ``` FAILURE: Build failed with an exception. * Where: Build file '/root/react-native/packages/react-native/ReactAndroid/build.gradle.kts' line: 784 * What went wrong: Script compilation errors: Line 784: react { ^ Unresolved reference: react Line 787: libraryName = "rncore" ^ Unresolved reference: libraryName Line 788: jsRootDir = file("../src") ^ Unresolved reference: jsRootDir ``` Changelog: [Internal] Reviewed By: arushikesarwani94 Differential Revision: D55618667 fbshipit-source-id: 1a188ba31b013863f3d46a773ff3ebbdd5f696cb --- .../src/main/kotlin/com/facebook/react/ReactPlugin.kt | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/ReactPlugin.kt b/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/ReactPlugin.kt index a06841d76d8..2c5bea4099c 100644 --- a/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/ReactPlugin.kt +++ b/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/ReactPlugin.kt @@ -38,10 +38,7 @@ import org.gradle.internal.jvm.Jvm class ReactPlugin : Plugin { override fun apply(project: Project) { checkJvmVersion(project) - val extension = - project.rootProject.extensions.findByType(ReactExtension::class.java) - ?: project.rootProject.extensions.create("react", ReactExtension::class.java, project) - + val extension = project.extensions.create("react", ReactExtension::class.java, project) checkIfNewArchFlagIsSet(project, extension) // We register a private extension on the rootProject so that project wide configs