From 245e5d9d951b36d578db29f218da77a274fff8d9 Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Thu, 18 Jul 2024 18:19:41 -0700 Subject: [PATCH] Remove experimental_boxShadow from Android base view config (#45529) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45529 `experimental_boxShadow` is not yet part of Android view managers, and when we enable it, we are likely to do a view manager at a time before moving to BaseViewManager. This causes user-visible errors when viewconfig validation is turned on, since we have a static view config, but not yet a native view config. This removes the static viewconfig for Android until we start adding setters to view manager. It is kept in `ReactNativeStyleAttributes` (which I think can have members not in the native view-config, since it has component specific props like tintColor), and iOS base viewconfig. On Fabric iOS, this is part of BaseViewProps, and handled by RCTView, but it looks like the prop (and also `experimental_filter`, `experimental_mixBlendMode`) do not have entries in iOS RCTViewManager, which is fixed in next diff in the stack. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D59939866 fbshipit-source-id: 2781029a0c29ba111ed04edfe9940c6c72f4e5ac --- .../Libraries/NativeComponent/BaseViewConfig.android.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/packages/react-native/Libraries/NativeComponent/BaseViewConfig.android.js b/packages/react-native/Libraries/NativeComponent/BaseViewConfig.android.js index 431c6810e9a..29f303eec7a 100644 --- a/packages/react-native/Libraries/NativeComponent/BaseViewConfig.android.js +++ b/packages/react-native/Libraries/NativeComponent/BaseViewConfig.android.js @@ -170,9 +170,6 @@ const validAttributesForNonEventProps = { process: require('../StyleSheet/processFilter').default, }, experimental_mixBlendMode: true, - experimental_boxShadow: { - process: require('../StyleSheet/processBoxShadow').default, - }, opacity: true, elevation: true, shadowColor: {process: require('../StyleSheet/processColor').default},