From 23f578779b48040760f47bbd97ca0e970c75041b Mon Sep 17 00:00:00 2001 From: Leo Natan Date: Fri, 31 May 2019 12:44:01 -0700 Subject: [PATCH] Fix incorrect unhooking for UI manager views in RCTProfileUnhookModules (#25042) Summary: This PR fixes incorrect unhooking for UI manager views in `RCTProfileUnhookModules`. `view` is actually a key, not the view itself; instead, use `viewForReactTag:` to obtain the view itself. This fixes issue #24952. ## Changelog [iOS] [Fixed] - Fix incorrect unhooking for UI manager views in `RCTProfileUnhookModules`, causing an infinite `RCTProfileTrampoline ` recursion (#24952) Pull Request resolved: https://github.com/facebook/react-native/pull/25042 Differential Revision: D15580978 Pulled By: PeteTheHeat fbshipit-source-id: 3483a7f6380b6fb1db4249374d86f692348c9aa2 --- React/Profiler/RCTProfile.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/React/Profiler/RCTProfile.m b/React/Profiler/RCTProfile.m index 98ba2e84333..4d7460268fa 100644 --- a/React/Profiler/RCTProfile.m +++ b/React/Profiler/RCTProfile.m @@ -350,7 +350,7 @@ void RCTProfileUnhookModules(RCTBridge *bridge) if ([bridge moduleIsInitialized:[RCTUIManager class]]) { dispatch_async(dispatch_get_main_queue(), ^{ for (id view in [bridge.uiManager valueForKey:@"viewRegistry"]) { - RCTProfileUnhookInstance(view); + RCTProfileUnhookInstance([bridge.uiManager viewForReactTag:view]); } dispatch_group_leave(RCTProfileGetUnhookGroup());