mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Pin clang-format 21.1.2 for OSS formatting (#58001)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/58001 The existing npm `clang-format` wrapper bundles LLVM 15, causing `yarn clang-format` to disagree with the formatting of checked-in headers. Replace it with checksum-pinned DotSlash artifacts for `clang-format` 21.1.2 across Linux, macOS, and Windows. Add a chunked formatting runner and remove the obsolete npm dependency. The runner skips generated sources and ignores dirsynchronized or vendored subtrees that maintain their own formatting. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D116500359 fbshipit-source-id: 2141bee22ed2b712aae1637a1f052db23535bbb0
This commit is contained in:
1 parent
0c86952e40
commit
22e0eaf4e7
5 files changed
+157
-16
No files matched your search
Executable
+77
@@ -0,0 +1,77 @@
|
||||
#!/usr/bin/env dotslash
|
||||
|
||||
// Copyright (c) Meta Platforms, Inc. and affiliates.
|
||||
//
|
||||
// This source code is licensed under the MIT license found in the
|
||||
// LICENSE file in the root directory of this source tree.
|
||||
|
||||
{
|
||||
"name": "clang-format 21.1.2",
|
||||
"platforms": {
|
||||
"linux-aarch64": {
|
||||
"size": 1725525,
|
||||
"hash": "sha256",
|
||||
"digest": "f66d2bcf98df1373df6ab4544a2b881e9816985b606e1144e4c77dc8ac87b826",
|
||||
"providers": [
|
||||
{
|
||||
"type": "http",
|
||||
"url": "https://files.pythonhosted.org/packages/c5/83/61fadfa8d62a288d778e0a1ad2f73b01abca64574ee34c5d6d078e0821da/clang_format-21.1.2-py2.py3-none-manylinux_2_26_aarch64.manylinux_2_28_aarch64.whl"
|
||||
}
|
||||
],
|
||||
"format": "zip",
|
||||
"path": "clang_format/data/bin/clang-format"
|
||||
},
|
||||
"linux-x86_64": {
|
||||
"size": 1805060,
|
||||
"hash": "sha256",
|
||||
"digest": "6d7caf74fe89154258ddfd63984c98ffe902ef98f013ac517178fc44d72861ff",
|
||||
"providers": [
|
||||
{
|
||||
"type": "http",
|
||||
"url": "https://files.pythonhosted.org/packages/fb/ac/3c04772acc0257f5730e83adb542b2603c1a62d1315010ab593a980af404/clang_format-21.1.2-py2.py3-none-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl"
|
||||
}
|
||||
],
|
||||
"format": "zip",
|
||||
"path": "clang_format/data/bin/clang-format"
|
||||
},
|
||||
"macos-aarch64": {
|
||||
"size": 1458874,
|
||||
"hash": "sha256",
|
||||
"digest": "fc034652dee24583633177d800bc9deebcc9c65eb7ab53b25bbd0fbd443392a9",
|
||||
"providers": [
|
||||
{
|
||||
"type": "http",
|
||||
"url": "https://files.pythonhosted.org/packages/ba/90/b8230efcff90a8543da3fb7fc09d7077afebaba019eceb1686d4db94cac3/clang_format-21.1.2-py2.py3-none-macosx_11_0_arm64.whl"
|
||||
}
|
||||
],
|
||||
"format": "zip",
|
||||
"path": "clang_format/data/bin/clang-format"
|
||||
},
|
||||
"macos-x86_64": {
|
||||
"size": 1440163,
|
||||
"hash": "sha256",
|
||||
"digest": "00498efb43d60d7ac4195362009a79936d26145a9a90cdfa7a6013a62ab3c40c",
|
||||
"providers": [
|
||||
{
|
||||
"type": "http",
|
||||
"url": "https://files.pythonhosted.org/packages/7d/97/0bb5a6866dfb5f55f7e6ca79466cb0b0081fccbc9f57887949ff23b5c38a/clang_format-21.1.2-py2.py3-none-macosx_10_9_x86_64.whl"
|
||||
}
|
||||
],
|
||||
"format": "zip",
|
||||
"path": "clang_format/data/bin/clang-format"
|
||||
},
|
||||
"windows-x86_64": {
|
||||
"size": 1426244,
|
||||
"hash": "sha256",
|
||||
"digest": "c98e195a50c0fa40bb058449511b1b681ca7ad553579aa32425f0cfeca8d81ce",
|
||||
"providers": [
|
||||
{
|
||||
"type": "http",
|
||||
"url": "https://files.pythonhosted.org/packages/fe/0d/3b9c6a41a9eed2d45431d91c0e8608da315cd44d0c24c517bfb686db4b6b/clang_format-21.1.2-py2.py3-none-win_amd64.whl"
|
||||
}
|
||||
],
|
||||
"format": "zip",
|
||||
"path": "clang_format/data/bin/clang-format.exe"
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,73 @@
|
||||
/**
|
||||
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @noflow
|
||||
* @format
|
||||
*/
|
||||
|
||||
'use strict';
|
||||
|
||||
const dotslash = require('fb-dotslash');
|
||||
const {spawnSync} = require('node:child_process');
|
||||
const fs = require('node:fs');
|
||||
const path = require('node:path');
|
||||
const {globSync} = require('tinyglobby');
|
||||
|
||||
const REPO_ROOT = path.resolve(__dirname, '..');
|
||||
const CLANG_FORMAT = path.join(__dirname, 'clang-format');
|
||||
const GENERATED_MARKER = Buffer.from('@' + 'generated');
|
||||
const MAX_HEADER_BYTES = 4096;
|
||||
const MAX_FILES_PER_PROCESS = 30;
|
||||
|
||||
/** @param {string} file */
|
||||
function isGenerated(file) {
|
||||
let fd;
|
||||
try {
|
||||
fd = fs.openSync(path.resolve(REPO_ROOT, file), 'r');
|
||||
const header = Buffer.alloc(MAX_HEADER_BYTES);
|
||||
const bytesRead = fs.readSync(fd, header, 0, header.length, 0);
|
||||
return header.subarray(0, bytesRead).includes(GENERATED_MARKER);
|
||||
} catch (error) {
|
||||
const message = error instanceof Error ? error.message : String(error);
|
||||
throw new Error(`Unable to inspect ${file}: ${message}`, {cause: error});
|
||||
} finally {
|
||||
if (fd != null) {
|
||||
fs.closeSync(fd);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
function main() {
|
||||
const files =
|
||||
process.argv.length > 2
|
||||
? process.argv.slice(2)
|
||||
: globSync('*/**/*.{h,cpp,m,mm}', {cwd: REPO_ROOT});
|
||||
const sourceFiles = files.filter(file => !isGenerated(file));
|
||||
|
||||
for (let i = 0; i < sourceFiles.length; i += MAX_FILES_PER_PROCESS) {
|
||||
const result = spawnSync(
|
||||
dotslash,
|
||||
[CLANG_FORMAT, '-i', ...sourceFiles.slice(i, i + MAX_FILES_PER_PROCESS)],
|
||||
{
|
||||
cwd: REPO_ROOT,
|
||||
stdio: 'inherit',
|
||||
},
|
||||
);
|
||||
|
||||
if (result.error != null) {
|
||||
throw result.error;
|
||||
}
|
||||
if (result.signal != null) {
|
||||
process.kill(process.pid, result.signal);
|
||||
return;
|
||||
}
|
||||
if (result.status !== 0) {
|
||||
process.exit(result.status ?? 1);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
main();
|
||||
Reference in new issue
Block a user