Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add an API for Detox to check if there are any timers expiring in a certain range (#27539)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/27539

Detox currently relies on reflection to inspect the private timers queue in the Timing module to check if React Native is idle or not. This broke when I renamed TimingModule and moved the queue to JavaTimerManager in D17260848 and D17282187. A better solution to this problem is for us to expose a public API for checking the timers queue from TimingModule, so that Detox doesn't need to access private fields.

Using similar logic to Detox's TimersIdlingResource: https://github.com/wix/Detox/blob/4f81a77baee4e4542a693922bcbde621d9d8c1a5/detox/android/detox/src/main/java/com/wix/detox/reactnative/idlingresources/TimersIdlingResource.kt#L95

Changelog: [Android] [Added] Added an API for checking if there are busy timers to TimingModule

Reviewed By: makovkastar

Differential Revision: D19128786

fbshipit-source-id: 835ae214eba58879c8343255bba680a81801ce03
This commit is contained in:
Emily Janzer
2020-01-07 15:36:37 -08:00
committed by Facebook Github Bot
parent 80cfa9c8ee
commit 22764e6cdc
4 changed files with 40 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/test/java/com/facebook/react/modules/BUCK
+1
View File
@@ -28,6 +28,7 @@ rn_robolectric_test(
react_native_target("java/com/facebook/react/common/network:network"),
react_native_target("java/com/facebook/react/devsupport:interfaces"),
react_native_target("java/com/facebook/react/jstasks:jstasks"),
react_native_target("java/com/facebook/react/module/annotations:annotations"),
react_native_target("java/com/facebook/react/modules/blob:blob"),
react_native_target("java/com/facebook/react/modules/camera:camera"),
react_native_target("java/com/facebook/react/modules/clipboard:clipboard"),
ReactAndroid/src/test/java/com/facebook/react/modules/timing/TimingModuleTest.java
+14
View File
@@ -7,6 +7,7 @@
package com.facebook.react.modules.timing;
import static org.fest.assertions.api.Assertions.assertThat;
import static org.mockito.Mockito.*;
import com.facebook.react.bridge.Arguments;
@@ -254,6 +255,19 @@ public class TimingModuleTest {
verify(mJSTimersMock).callIdleCallbacks(SystemClock.currentTimeMillis());
}
@Test
public void testActiveTimersInRange() {
mTimingModule.onHostResume();
assertThat(mTimingModule.hasActiveTimersInRange(100)).isFalse();
mTimingModule.createTimer(41, 1, 0, true);
assertThat(mTimingModule.hasActiveTimersInRange(100)).isFalse(); // Repeating
mTimingModule.createTimer(42, 150, 0, false);
assertThat(mTimingModule.hasActiveTimersInRange(100)).isFalse(); // Out of range
assertThat(mTimingModule.hasActiveTimersInRange(200)).isTrue(); // In range
}
private static class PostFrameIdleCallbackHandler implements Answer<Void> {
private ChoreographerCompat.FrameCallback mFrameCallback;