- Add null/undefined check for error handling

Summary: Same as title. Changing as per suggestion.

Reviewed By: furdei

Differential Revision: D16615807

fbshipit-source-id: 1c35ae1471beb2460e975841f367ffd49ce34494
This commit is contained in:
Sensen Chen
2019-08-01 20:41:35 -07:00
committed by Facebook Github Bot
parent 9420de6860
commit 2198203ddb
@@ -7,6 +7,7 @@
package com.facebook.react.modules.core;
import com.facebook.common.logging.FLog;
import com.facebook.react.bridge.Arguments;
import com.facebook.react.bridge.BaseJavaModule;
import com.facebook.react.bridge.JavaOnlyMap;
import com.facebook.react.bridge.ReactMethod;
@@ -57,10 +58,11 @@ public class ExceptionsManagerModule extends BaseJavaModule {
@ReactMethod
public void reportException(ReadableMap data) {
String message = data.getString("message");
ReadableArray stack = data.getArray("stack");
int id = data.getInt("id");
boolean isFatal = data.getBoolean("isFatal");
String message = data.hasKey("message") ? data.getString("message") : "";
ReadableArray stack = data.hasKey("stack") ? data.getArray("stack") : Arguments.createArray();
int id = data.hasKey("id") ? data.getInt("id") : -1;
boolean isFatal = data.hasKey("isFatal") ? data.getBoolean("isFatal") : false;
if (mDevSupportManager.getDevSupportEnabled()) {
mDevSupportManager.showNewJSError(message, stack, id);
} else {