From 21204d750efcceba8d5ac1f83f5a4fd8d7f017bb Mon Sep 17 00:00:00 2001 From: "Andrew Chen (Eng)" Date: Wed, 3 Oct 2018 18:20:18 -0700 Subject: [PATCH] Fix accessibility role/label Summary: D10138128 had some shamefully wrong boolean logic to determine whether we should customize the accessibility delegate. Previously, we did it if BOTH the accessibility label AND role were present. We should actually do it if EITHER are present. Reviewed By: mdvacca Differential Revision: D10182135 fbshipit-source-id: 209a8ab43f5869762843fe878cfd59a7b9b5ab1a --- .../facebook/react/uimanager/AccessibilityDelegateUtil.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/AccessibilityDelegateUtil.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/AccessibilityDelegateUtil.java index 583424bc267..35c5e0c6f88 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/AccessibilityDelegateUtil.java +++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/AccessibilityDelegateUtil.java @@ -76,8 +76,7 @@ public class AccessibilityDelegateUtil { // if a view already has an accessibility delegate, replacing it could cause problems, // so leave it alone. if (!ViewCompat.hasAccessibilityDelegate(view) && - accessibilityHint != null && - accessibilityRole != null) { + (accessibilityHint != null || accessibilityRole != null)) { ViewCompat.setAccessibilityDelegate( view, new AccessibilityDelegateCompat() {