Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

2/n Code clarity: Use enum to clarify the values parsed by JsErrorHandler

Browse Source 
Summary:
Changelog: [Internal] Code clarity: Use enum to clarify the values parsed by JsErrorHandler

Create a enum `JSErrorHandlerKey` to define the keys for the values that goes into each stack frame.

Next up -- using this in the Bridge!

Reviewed By: sammy-SC

Differential Revision: D40326127

fbshipit-source-id: e416814fbcaa922afa92d9baf79eaa898ff979f0
This commit is contained in:
Paige Sun
2022-10-14 10:48:47 -07:00
committed by Facebook GitHub Bot
parent 4631cf933e
commit 20c9654ca7
2 changed files with 28 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/jserrorhandler/JsErrorHandler.cpp
+18 -16
View File
@@ -15,6 +15,8 @@
namespace facebook {
namespace react {
using facebook::react::JSErrorHandlerKey;
static MapBuffer
parseErrorStack(const jsi::JSError &error, bool isFatal, bool isHermes) {
/**
@@ -53,37 +55,37 @@ parseErrorStack(const jsi::JSError &error, bool isFatal, bool isHermes) {
if (std::regex_search(line, searchResults, REGEX_HERMES)) {
std::string str2 = std::string(searchResults[2]);
if (str2.compare("native")) {
frame.putString(0, std::string(searchResults[4]));
frame.putString(1, std::string(searchResults[1]));
frame.putInt(2, std::stoi(searchResults[5]));
frame.putInt(3, std::stoi(searchResults[6]));
frame.putString(kFrameFileName, std::string(searchResults[4]));
frame.putString(kFrameMethodName, std::string(searchResults[1]));
frame.putInt(kFrameLineNumber, std::stoi(searchResults[5]));
frame.putInt(kFrameColumnNumber, std::stoi(searchResults[6]));
frames.push_back(frame.build());
}
}
} else {
if (std::regex_search(line, searchResults, REGEX_GECKO)) {
frame.putString(0, std::string(searchResults[3]));
frame.putString(1, std::string(searchResults[1]));
frame.putInt(2, std::stoi(searchResults[4]));
frame.putInt(3, std::stoi(searchResults[5]));
frame.putString(kFrameFileName, std::string(searchResults[3]));
frame.putString(kFrameMethodName, std::string(searchResults[1]));
frame.putInt(kFrameLineNumber, std::stoi(searchResults[4]));
frame.putInt(kFrameColumnNumber, std::stoi(searchResults[5]));
} else if (
std::regex_search(line, searchResults, REGEX_CHROME) ||
std::regex_search(line, searchResults, REGEX_NODE)) {
frame.putString(0, std::string(searchResults[2]));
frame.putString(1, std::string(searchResults[1]));
frame.putInt(2, std::stoi(searchResults[3]));
frame.putInt(3, std::stoi(searchResults[4]));
frame.putString(kFrameFileName, std::string(searchResults[2]));
frame.putString(kFrameMethodName, std::string(searchResults[1]));
frame.putInt(kFrameLineNumber, std::stoi(searchResults[3]));
frame.putInt(kFrameColumnNumber, std::stoi(searchResults[4]));
} else {
continue;
}
frames.push_back(frame.build());
}
}
errorObj.putMapBufferList(4, std::move(frames));
errorObj.putString(5, error.getMessage());
errorObj.putMapBufferList(kAllStackFrames, std::move(frames));
errorObj.putString(kErrorMessage, error.getMessage());
// TODO: If needed, can increment exceptionId by 1 each time
errorObj.putInt(6, 0);
errorObj.putBool(7, isFatal);
errorObj.putInt(kExceptionId, 0);
errorObj.putBool(kIsFatal, isFatal);
return errorObj.build();
}