From 2013bad2544fbcfa418c22f8fe647369d350df6d Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Tue, 14 Jan 2025 08:20:05 -0800 Subject: [PATCH] Back out "RN: Enable `useInsertionEffectsForAnimations`" (#48669) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48669 Original commit changeset: d09b2f1b7607 Original Phabricator Diff: D65906157 [General] [Fixed] - Disable useInsertionEffectsForAnimations, Fix buttons becoming unresponsive when transform is animated Reviewed By: yungsters Differential Revision: D68152746 fbshipit-source-id: aa0c0aa3243c67c95128a75b40dd6aa1251abbca --- .../scripts/featureflags/ReactNativeFeatureFlags.config.js | 6 ++++-- .../src/private/featureflags/ReactNativeFeatureFlags.js | 6 +++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js b/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js index ca1db072363..c1e0bf0a8a8 100644 --- a/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js +++ b/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js @@ -546,11 +546,13 @@ const definitions: FeatureFlagDefinitions = { }, }, useInsertionEffectsForAnimations: { - defaultValue: true, + defaultValue: false, metadata: { + dateAdded: '2024-09-12', description: 'Changes construction of the animation graph to `useInsertionEffect` instead of `useLayoutEffect`.', - purpose: 'release', + expectedReleaseValue: true, + purpose: 'experimentation', }, }, useRefsForTextInputState: { diff --git a/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js b/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js index 8ca49c8d909..462231ad955 100644 --- a/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js +++ b/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js @@ -4,7 +4,11 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * +<<<<<<< HEAD * @generated SignedSource<<83b5798ee1c7a28fffbf110e19641d69>> +======= + * @generated SignedSource<<3bdec862f75745ce81e9cf23fef82468>> +>>>>>>> c799aa07e21 (Back out "RN: Enable `useInsertionEffectsForAnimations`" (#48669)) * @flow strict */ @@ -170,7 +174,7 @@ export const shouldUseSetNativePropsInFabric: Getter = createJavaScript /** * Changes construction of the animation graph to `useInsertionEffect` instead of `useLayoutEffect`. */ -export const useInsertionEffectsForAnimations: Getter = createJavaScriptFlagGetter('useInsertionEffectsForAnimations', true); +export const useInsertionEffectsForAnimations: Getter = createJavaScriptFlagGetter('useInsertionEffectsForAnimations', false); /** * Enable a variant of TextInput that moves some state to refs to avoid unnecessary re-renders