From 1fa3a8e4752fb7b34aaa8b464d7a678427f65ed4 Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Tue, 9 Jun 2020 02:28:18 -0700 Subject: [PATCH] Form stacking context if display style is none Summary: Changelog: [Internal] View gets flattened even though it has `display: none` and therefore it and its children do not get hidden. Reviewed By: shergin, mdvacca Differential Revision: D21929033 fbshipit-source-id: 994a79fb64fbe66273a70218ebe8056d92cd3cd4 --- ReactCommon/fabric/components/view/ViewShadowNode.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/ReactCommon/fabric/components/view/ViewShadowNode.cpp b/ReactCommon/fabric/components/view/ViewShadowNode.cpp index 024318662f3..43b6b7229d4 100644 --- a/ReactCommon/fabric/components/view/ViewShadowNode.cpp +++ b/ReactCommon/fabric/components/view/ViewShadowNode.cpp @@ -46,6 +46,7 @@ void ViewShadowNode::initialize() noexcept { viewProps.elevation != 0 || (viewProps.zIndex != 0 && viewProps.yogaStyle.positionType() == YGPositionTypeAbsolute) || + viewProps.yogaStyle.display() == YGDisplayNone || viewProps.getClipsContentToBounds() || isColorMeaningful(viewProps.shadowColor);