Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use reference for command args

Browse Source 
Summary:
The IDE warning suggests that passing folly::dynamic by value will create a copy on each call.

Changelog: [Internal]

Reviewed By: JoshuaGross

Differential Revision: D32978154

fbshipit-source-id: a47a60c332a9d299eb2110d3537dfab0bc2398b6
This commit is contained in:
Andrei Shikov
2021-12-09 09:47:38 -08:00
committed by Facebook GitHub Bot
parent 891a1c12f1
commit 1d4e7f6d40
11 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp
+1 -1
View File
@@ -1295,7 +1295,7 @@ void Binding::schedulerDidCloneShadowNode(
void Binding::schedulerDidDispatchCommand(
const ShadowView &shadowView,
std::string const &commandName,
folly::dynamic const args) {
folly::dynamic const &args) {
jni::global_ref<jobject> localJavaUIManager = getJavaUIManager();
if (!localJavaUIManager) {
LOG(ERROR)
ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.h
+1 -1
View File
@@ -156,7 +156,7 @@ class Binding : public jni::HybridClass<Binding>,
void schedulerDidDispatchCommand(
const ShadowView &shadowView,
std::string const &commandName,
folly::dynamic const args) override;
folly::dynamic const &args) override;
void schedulerDidSendAccessibilityEvent(
const ShadowView &shadowView,