mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Use reference for command args
Summary: The IDE warning suggests that passing folly::dynamic by value will create a copy on each call. Changelog: [Internal] Reviewed By: JoshuaGross Differential Revision: D32978154 fbshipit-source-id: a47a60c332a9d299eb2110d3537dfab0bc2398b6
This commit is contained in:
1 parent
891a1c12f1
commit
1d4e7f6d40
11 files changed
+11
-11
No files matched your search
@@ -1295,7 +1295,7 @@ void Binding::schedulerDidCloneShadowNode(
|
||||
void Binding::schedulerDidDispatchCommand(
|
||||
const ShadowView &shadowView,
|
||||
std::string const &commandName,
|
||||
folly::dynamic const args) {
|
||||
folly::dynamic const &args) {
|
||||
jni::global_ref<jobject> localJavaUIManager = getJavaUIManager();
|
||||
if (!localJavaUIManager) {
|
||||
LOG(ERROR)
|
||||
|
||||
@@ -156,7 +156,7 @@ class Binding : public jni::HybridClass<Binding>,
|
||||
void schedulerDidDispatchCommand(
|
||||
const ShadowView &shadowView,
|
||||
std::string const &commandName,
|
||||
folly::dynamic const args) override;
|
||||
folly::dynamic const &args) override;
|
||||
|
||||
void schedulerDidSendAccessibilityEvent(
|
||||
const ShadowView &shadowView,
|
||||
|
||||
Reference in new issue
Block a user