Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor: Stop having DevSupportManager conform to PackagerCommandListener

Browse Source 
Summary:
## Rationale
The public methods of PackagerCommandListener should not be a part of the public API of DevSupportManagerBase. It's cleaner to just create a new PackagerCommandListener object inline, when we need it. This way, there're are less methods to think about when reasoning about the public API of DevSupportManagerBase.

Changelog: [Internal]

Reviewed By: JoshuaGross

Differential Revision: D29006835

fbshipit-source-id: 0eea86c22e7d676c94d29b240a1f39955d8216ab
This commit is contained in:
Ramanpreet Nara
2021-06-10 16:47:20 -07:00
committed by Facebook GitHub Bot
parent 675e480fb9
commit 1d14df217e
1 changed files with 54 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java
+54 -52
View File
@@ -60,7 +60,7 @@ import java.util.List;
import java.util.Locale;
import java.util.Map;
public abstract class DevSupportManagerBase implements DevSupportManager, PackagerCommandListener {
public abstract class DevSupportManagerBase implements DevSupportManager {
public interface CallbackWithBundleLoader {
void onSuccess(JSBundleLoader bundleLoader);
@@ -966,56 +966,6 @@ public abstract class DevSupportManagerBase implements DevSupportManager, Packag
return mLastErrorType;
}
@Override
public void onPackagerConnected() {
// No-op
}
@Override
public void onPackagerDisconnected() {
// No-op
}
@Override
public void onPackagerReloadCommand() {
// Disable debugger to resume the JsVM & avoid thread locks while reloading
mDevServerHelper.disableDebugger();
UiThreadUtil.runOnUiThread(
new Runnable() {
@Override
public void run() {
handleReloadJS();
}
});
}
@Override
public void onPackagerDevMenuCommand() {
UiThreadUtil.runOnUiThread(
new Runnable() {
@Override
public void run() {
showDevOptionsDialog();
}
});
}
@Override
public void onCaptureHeapCommand(final Responder responder) {
UiThreadUtil.runOnUiThread(
new Runnable() {
@Override
public void run() {
handleCaptureHeap(responder);
}
});
}
@Override
public @Nullable Map<String, RequestHandler> customCommandHandlers() {
return mCustomPackagerCommandHandlers;
}
private void handleCaptureHeap(final Responder responder) {
if (mCurrentContext == null) {
return;
@@ -1240,7 +1190,59 @@ public abstract class DevSupportManagerBase implements DevSupportManager, Packag
mDevLoadingViewController.showMessage("Reloading...");
}
mDevServerHelper.openPackagerConnection(this.getClass().getSimpleName(), this);
mDevServerHelper.openPackagerConnection(
this.getClass().getSimpleName(),
new PackagerCommandListener() {
@Override
public void onPackagerConnected() {
// No-op
}
@Override
public void onPackagerDisconnected() {
// No-op
}
@Override
public void onPackagerReloadCommand() {
// Disable debugger to resume the JsVM & avoid thread locks while reloading
mDevServerHelper.disableDebugger();
UiThreadUtil.runOnUiThread(
new Runnable() {
@Override
public void run() {
handleReloadJS();
}
});
}
@Override
public void onPackagerDevMenuCommand() {
UiThreadUtil.runOnUiThread(
new Runnable() {
@Override
public void run() {
showDevOptionsDialog();
}
});
}
@Override
public void onCaptureHeapCommand(final Responder responder) {
UiThreadUtil.runOnUiThread(
new Runnable() {
@Override
public void run() {
handleCaptureHeap(responder);
}
});
}
@Override
public @Nullable Map<String, RequestHandler> customCommandHandlers() {
return mCustomPackagerCommandHandlers;
}
});
} else {
// hide FPS debug overlay
if (mDebugOverlayController != null) {