From 1cd9aa2dea12666108193823691c806123463bd4 Mon Sep 17 00:00:00 2001 From: Alex Dvornikov Date: Fri, 10 Aug 2018 09:26:18 -0700 Subject: [PATCH] Add REGISTER_JS_SEGMENT perf markers Reviewed By: cwdick Differential Revision: D9244289 fbshipit-source-id: 9004a0405f9622cbd0bbb837b99df32454f35bb8 --- React/CxxBridge/RCTCxxBridge.mm | 2 ++ .../com/facebook/react/bridge/ReactMarkerConstants.java | 2 ++ ReactAndroid/src/main/jni/react/jni/JReactMarker.cpp | 6 ++++++ ReactCommon/cxxreact/ReactMarker.h | 2 ++ 4 files changed, 12 insertions(+) diff --git a/React/CxxBridge/RCTCxxBridge.mm b/React/CxxBridge/RCTCxxBridge.mm index a35425efdd1..7d290fab551 100644 --- a/React/CxxBridge/RCTCxxBridge.mm +++ b/React/CxxBridge/RCTCxxBridge.mm @@ -121,6 +121,8 @@ static void registerPerformanceLoggerHooks(RCTPerformanceLogger *performanceLogg case ReactMarker::JS_BUNDLE_STRING_CONVERT_STOP: case ReactMarker::NATIVE_MODULE_SETUP_START: case ReactMarker::NATIVE_MODULE_SETUP_STOP: + case ReactMarker::REGISTER_JS_SEGMENT_START: + case ReactMarker::REGISTER_JS_SEGMENT_STOP: // These are not used on iOS. break; } diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactMarkerConstants.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactMarkerConstants.java index c3dffabbaa7..87fdd536e6a 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactMarkerConstants.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactMarkerConstants.java @@ -85,4 +85,6 @@ public enum ReactMarkerConstants { CREATE_MC_MODULE_END, CREATE_MC_MODULE_GET_METADATA_START, CREATE_MC_MODULE_GET_METADATA_END, + REGISTER_JS_SEGMENT_START, + REGISTER_JS_SEGMENT_STOP, } diff --git a/ReactAndroid/src/main/jni/react/jni/JReactMarker.cpp b/ReactAndroid/src/main/jni/react/jni/JReactMarker.cpp index ead1c689d12..64c35b12ef5 100644 --- a/ReactAndroid/src/main/jni/react/jni/JReactMarker.cpp +++ b/ReactAndroid/src/main/jni/react/jni/JReactMarker.cpp @@ -53,6 +53,12 @@ void JReactMarker::logPerfMarker(const ReactMarker::ReactMarkerId markerId, cons case ReactMarker::NATIVE_MODULE_SETUP_STOP: JReactMarker::logMarker("NATIVE_MODULE_SETUP_END", tag); break; + case ReactMarker::REGISTER_JS_SEGMENT_START: + JReactMarker::logMarker("REGISTER_JS_SEGMENT_START", tag); + break; + case ReactMarker::REGISTER_JS_SEGMENT_STOP: + JReactMarker::logMarker("REGISTER_JS_SEGMENT_STOP", tag); + break; case ReactMarker::NATIVE_REQUIRE_START: case ReactMarker::NATIVE_REQUIRE_STOP: // These are not used on Android. diff --git a/ReactCommon/cxxreact/ReactMarker.h b/ReactCommon/cxxreact/ReactMarker.h index 3a71579ab8f..a67ed8c8e59 100644 --- a/ReactCommon/cxxreact/ReactMarker.h +++ b/ReactCommon/cxxreact/ReactMarker.h @@ -23,6 +23,8 @@ enum ReactMarkerId { JS_BUNDLE_STRING_CONVERT_STOP, NATIVE_MODULE_SETUP_START, NATIVE_MODULE_SETUP_STOP, + REGISTER_JS_SEGMENT_START, + REGISTER_JS_SEGMENT_STOP }; #ifdef __APPLE__