From 1c706cd03f26963e9e10ec6f239d26c1d616aeee Mon Sep 17 00:00:00 2001 From: Tim Yung Date: Sun, 16 Jun 2024 12:15:49 -0700 Subject: [PATCH] RN: Delete Shallow Renderer Cases in `ImageBackground-test.js` (#44980) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/44980 These Jest unit test cases were making assertions about shallow rendering, but that shallow rendering is now deprecated. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D58643065 fbshipit-source-id: 34a31989f298535546a64c3ccd2888d648c1cdf1 --- .../Image/__tests__/ImageBackground-test.js | 24 +----------- .../ImageBackground-test.js.snap | 38 ++----------------- 2 files changed, 4 insertions(+), 58 deletions(-) diff --git a/packages/react-native/Libraries/Image/__tests__/ImageBackground-test.js b/packages/react-native/Libraries/Image/__tests__/ImageBackground-test.js index 85e1122b5d2..473372c11e6 100644 --- a/packages/react-native/Libraries/Image/__tests__/ImageBackground-test.js +++ b/packages/react-native/Libraries/Image/__tests__/ImageBackground-test.js @@ -15,7 +15,7 @@ const render = require('../../../jest/renderer'); const ImageBackground = require('../ImageBackground'); const React = require('react'); -describe('', () => { +describe('ImageBackground', () => { it('should render as when mocked', () => { const instance = render.create( ', () => { expect(instance).toMatchSnapshot(); }); - it('should shallow render as when mocked', () => { - const output = render.shallow( - , - ); - expect(output).toMatchSnapshot(); - }); - - it('should shallow render as when not mocked', () => { - jest.dontMock('../ImageBackground'); - - const output = render.shallow( - , - ); - expect(output).toMatchSnapshot(); - }); - it('should render as when not mocked', () => { jest.dontMock('../ImageBackground'); diff --git a/packages/react-native/Libraries/Image/__tests__/__snapshots__/ImageBackground-test.js.snap b/packages/react-native/Libraries/Image/__tests__/__snapshots__/ImageBackground-test.js.snap index 348e31269ba..a06d47918be 100644 --- a/packages/react-native/Libraries/Image/__tests__/__snapshots__/ImageBackground-test.js.snap +++ b/packages/react-native/Libraries/Image/__tests__/__snapshots__/ImageBackground-test.js.snap @@ -1,6 +1,6 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[` should be set importantForAccessibility in and 1`] = ` +exports[`ImageBackground should be set importantForAccessibility in and 1`] = ` should be set importantForAccessibility in a `; -exports[` should render as when mocked 1`] = ` +exports[`ImageBackground should render as when mocked 1`] = ` should render as when mocked 1`] `; -exports[` should render as when not mocked 1`] = ` +exports[`ImageBackground should render as when not mocked 1`] = ` should render as when not mocked 1`] /> `; - -exports[` should shallow render as when not mocked 1`] = ` - -`; - -exports[` should shallow render as when mocked 1`] = ` - -`;