mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Do not reset the native artifacts version to 1000.0.0 on release branches (#53817)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/53817 What is currently happening, is that the various commits on the release branches like `0.82-stable` are resetting the version of native artifacts to `1000.0.0-<SHA>`. The reason is that during the `test-all` workflow, we pass the `dry-run` as release type. That's to prevent the various tools from calling `npm publish` and so on. The problem is that on the releases branches, the version was already set at branch cut time. Therefore, we see the version 1000.0.0 reappearing during Android E2E test in the emulator. Similary this is also affecting iOS prebuilds so I'm attempting to fix it here. Changelog: [Internal] [Changed] - Reviewed By: huntie Differential Revision: D82553599 fbshipit-source-id: 31a52e7df036e700663b3d3dd677973a7a210a30
This commit is contained in:
1 parent
5b8827939d
commit
1c5e0ffd9f
2 files changed
+22
-6
No files matched your search
@@ -17,6 +17,9 @@ runs:
|
||||
- name: Install node dependencies
|
||||
uses: ./.github/actions/yarn-install
|
||||
- name: Set React Native Version
|
||||
# We don't want to set the version for stable branches, because this has been
|
||||
# already set from the 'create release' commits on the release branch.
|
||||
if: ${{ !endsWith(github.ref_name, '-stable') }}
|
||||
shell: bash
|
||||
run: node ./scripts/releases/set-rn-artifacts-version.js --build-type ${{ inputs.release-type }}
|
||||
- name: Setup gradle
|
||||
|
||||
Reference in new issue
Block a user