From 1be852781d9105f509d2f02ff6e08e6117a27d1d Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Thu, 4 Sep 2025 23:31:08 -0700 Subject: [PATCH] Add tests for isHermesV1Enabled (#53601) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/53601 Changelog: [Internal] Adds tests covering the `isHermesV1Enabled` utility function. Reviewed By: cortinico Differential Revision: D81681635 fbshipit-source-id: c2c50db65f93b8b58ce1730ccfdf4367a024ce7b --- .../facebook/react/utils/ProjectUtilsTest.kt | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/packages/gradle-plugin/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/utils/ProjectUtilsTest.kt b/packages/gradle-plugin/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/utils/ProjectUtilsTest.kt index 81ec6744f00..2e1e3590fe1 100644 --- a/packages/gradle-plugin/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/utils/ProjectUtilsTest.kt +++ b/packages/gradle-plugin/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/utils/ProjectUtilsTest.kt @@ -14,6 +14,7 @@ import com.facebook.react.tests.createProject import com.facebook.react.utils.ProjectUtils.getReactNativeArchitectures import com.facebook.react.utils.ProjectUtils.isEdgeToEdgeEnabled import com.facebook.react.utils.ProjectUtils.isHermesEnabled +import com.facebook.react.utils.ProjectUtils.isHermesV1Enabled import com.facebook.react.utils.ProjectUtils.isNewArchEnabled import com.facebook.react.utils.ProjectUtils.needsCodegenFromPackageJson import java.io.File @@ -115,6 +116,32 @@ class ProjectUtilsTest { assertThat(project.isEdgeToEdgeEnabled).isFalse() } + @Test + fun isHermesV1Enabled_returnsFalseByDefault() { + assertThat(createProject().isHermesV1Enabled).isFalse() + } + + @Test + fun isHermesV1Enabled_withDisabledViaProperty_returnsFalse() { + val project = createProject() + project.extensions.extraProperties.set("hermesV1Enabled", "false") + assertThat(project.isHermesV1Enabled).isFalse() + } + + @Test + fun isHermesV1Enabled_withEnabledViaProperty_returnsTrue() { + val project = createProject() + project.extensions.extraProperties.set("hermesV1Enabled", "true") + assertThat(project.isHermesV1Enabled).isTrue() + } + + @Test + fun isHermesV1Enabled_withInvalidViaProperty_returnsFalse() { + val project = createProject() + project.extensions.extraProperties.set("hermesV1Enabled", "¯\\_(ツ)_/¯") + assertThat(project.isHermesV1Enabled).isFalse() + } + @Test fun needsCodegenFromPackageJson_withCodegenConfigInPackageJson_returnsTrue() { val project = createProject()