diff --git a/scripts/cocoapods/__tests__/flipper-test.rb b/scripts/cocoapods/__tests__/flipper-test.rb index feffeb5c49a..abea34a157e 100644 --- a/scripts/cocoapods/__tests__/flipper-test.rb +++ b/scripts/cocoapods/__tests__/flipper-test.rb @@ -85,7 +85,7 @@ class FlipperTests < Test::Unit::TestCase reactCore_target = installer.target_with_name("React-Core") reactCore_target.build_configurations.each do |config| - if config.name == 'Debug' then + if config.name == 'Debug' || config.name == 'CustomConfig' then assert_equal(config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'], ['$(inherited)', 'FB_SONARKIT_ENABLED=1']) else assert_true(config.build_settings.empty?) @@ -134,15 +134,17 @@ class FlipperTests < Test::Unit::TestCase TargetMock.new( "YogaKit", [ - BuildConfigurationMock.new("Debug"), - BuildConfigurationMock.new("Release"), + BuildConfigurationMock.new("Debug", is_debug: true), + BuildConfigurationMock.new("Release", is_debug: false), + BuildConfigurationMock.new("CustomConfig", is_debug: true), ] ), TargetMock.new( "React-Core", [ - BuildConfigurationMock.new("Debug"), - BuildConfigurationMock.new("Release"), + BuildConfigurationMock.new("Debug", is_debug: true), + BuildConfigurationMock.new("Release", is_debug: false), + BuildConfigurationMock.new("CustomConfig", is_debug: true), ] ) ] diff --git a/scripts/cocoapods/__tests__/test_utils/InstallerMock.rb b/scripts/cocoapods/__tests__/test_utils/InstallerMock.rb index e58cbbef716..f10a6109b69 100644 --- a/scripts/cocoapods/__tests__/test_utils/InstallerMock.rb +++ b/scripts/cocoapods/__tests__/test_utils/InstallerMock.rb @@ -174,10 +174,16 @@ end class BuildConfigurationMock attr_reader :name attr_reader :build_settings + @is_debug - def initialize(name, build_settings = {}) + def initialize(name, build_settings = {}, is_debug: false) @name = name @build_settings = build_settings + @is_debug = is_debug + end + + def debug? + return @is_debug end end diff --git a/scripts/cocoapods/flipper.rb b/scripts/cocoapods/flipper.rb index e2bfe76fdf6..5bf0d01c5b6 100644 --- a/scripts/cocoapods/flipper.rb +++ b/scripts/cocoapods/flipper.rb @@ -83,7 +83,7 @@ def flipper_post_install(installer) # Enable flipper for React-Core Debug configuration if target.name == 'React-Core' target.build_configurations.each do |config| - if config.name == 'Debug' + if config.debug? config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] = ['$(inherited)', 'FB_SONARKIT_ENABLED=1'] end end