From 1b741db6354e9370974a806cd50a86617dec3e49 Mon Sep 17 00:00:00 2001 From: Phillip Pan Date: Wed, 3 May 2023 15:46:55 -0700 Subject: [PATCH] do not expose jsThreadManager from RCTInstance (#37210) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/37210 Changelog: [Internal] no need to expose this Reviewed By: christophpurrer Differential Revision: D45507159 fbshipit-source-id: 1467dba09d6359f73996d0d0eeb246eb3f59e96c --- .../ReactCommon/react/bridgeless/platform/ios/Core/RCTHost.h | 2 -- .../react/bridgeless/platform/ios/Core/RCTHost.mm | 5 ----- .../react/bridgeless/platform/ios/Core/RCTInstance.h | 2 -- .../react/bridgeless/platform/ios/Core/RCTInstance.mm | 1 + 4 files changed, 1 insertion(+), 9 deletions(-) diff --git a/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTHost.h b/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTHost.h index 8fd3b488f93..fb06e707025 100644 --- a/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTHost.h +++ b/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTHost.h @@ -69,8 +69,6 @@ RCT_EXTERN NSString *const RCTHostDidReloadNotification; - (RCTFabricSurface *)createSurfaceWithModuleName:(NSString *)moduleName initialProperties:(NSDictionary *)properties FB_OBJC_DIRECT; -- (RCTJSThreadManager *)getJSThreadManager FB_OBJC_DIRECT; - - (RCTModuleRegistry *)getModuleRegistry FB_OBJC_DIRECT; - (NSArray *)getLoggingData FB_OBJC_DIRECT; diff --git a/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTHost.mm b/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTHost.mm index 6861a66a88a..14b0e9b6692 100644 --- a/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTHost.mm +++ b/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTHost.mm @@ -192,11 +192,6 @@ NSString *const RCTHostDidReloadNotification = @"RCTHostDidReloadNotification"; return [self createSurfaceWithModuleName:moduleName mode:DisplayMode::Visible initialProperties:properties]; } -- (RCTJSThreadManager *)getJSThreadManager -{ - return [_instance jsThreadManager]; -} - - (RCTModuleRegistry *)getModuleRegistry { return _moduleRegistry; diff --git a/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTInstance.h b/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTInstance.h index 69f6484aa94..8411fe05738 100644 --- a/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTInstance.h +++ b/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTInstance.h @@ -86,8 +86,6 @@ typedef void (^_Null_unspecified RCTInstanceInitialBundleLoadCompletionBlock)(); - (void)invalidate; -@property (nonatomic, readonly, strong, FB_DIRECT) RCTJSThreadManager *jsThreadManager; - @property (nonatomic, readonly, strong) RCTPerformanceLogger *performanceLogger; @property (nonatomic, readonly, strong) RCTSurfacePresenter *surfacePresenter; diff --git a/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTInstance.mm b/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTInstance.mm index b0db0c40946..520c0b471e0 100644 --- a/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTInstance.mm +++ b/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTInstance.mm @@ -76,6 +76,7 @@ void RCTInstanceSetRuntimeDiagnosticFlags(NSString *flags) JsErrorHandler::JsErrorHandlingFunc _jsErrorHandlingFunc; std::mutex _invalidationMutex; std::atomic _valid; + RCTJSThreadManager *_jsThreadManager; // APIs supporting interop with native modules and view managers RCTBridgeModuleDecorator *_bridgeModuleDecorator;