From 1b1b26a099cc2f213bb270bfc0e56a202e618638 Mon Sep 17 00:00:00 2001
From: Samuel Susla <samuelsusla@meta.com>
Date: Thu, 10 Nov 2022 10:43:47 -0800
Subject: [PATCH] Call setNativeView anytime node changes

Summary:
changelog: [internal]

Call `AnimatedProps.setNativeView` any time `AnimatedProps` node changes to make sure it is always connected to underlaying host component.

Reviewed By: yungsters

Differential Revision: D41122065

fbshipit-source-id: 1d10fdd44933ff82d9bfc424cecb2640b7a66837
---
 Libraries/Animated/useAnimatedProps.js | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/Libraries/Animated/useAnimatedProps.js b/Libraries/Animated/useAnimatedProps.js
index 1b7d81009fd..b63d5478976 100644
--- a/Libraries/Animated/useAnimatedProps.js
+++ b/Libraries/Animated/useAnimatedProps.js
@@ -35,6 +35,7 @@ export default function useAnimatedProps<TProps: {...}, TInstance>(
 ): [ReducedProps<TProps>, CallbackRef<TInstance | null>] {
   const [, scheduleUpdate] = useReducer<number, void>(count => count + 1, 0);
   const onUpdateRef = useRef<?() => void>(null);
+  const cachedRef = useRef<TInstance | null>(null);
 
   // TODO: Only invalidate `node` if animated props or `style` change. In the
   // previous implementation, we permitted `style` to override props with the
@@ -64,6 +65,7 @@ export default function useAnimatedProps<TProps: {...}, TInstance>(
       // NOTE: This may be called more often than necessary (e.g. when `props`
       // changes), but `setNativeView` already optimizes for that.
       node.setNativeView(instance);
+      cachedRef.current = instance;
 
       // NOTE: This callback is only used by the JavaScript animation driver.
       onUpdateRef.current = () => {
@@ -113,6 +115,16 @@ export default function useAnimatedProps<TProps: {...}, TInstance>(
   );
   const callbackRef = useRefEffect<TInstance>(refEffect);
 
+  useEffect(() => {
+    // Call `setNativeView` any time `node` changes to make sure
+    // `AnimatedProps._animatedView` is up to date.
+    // This would not be necessary in an ideal world.
+    // In React, anytime identity of function passed to `ref` changes,
+    // the old function is called with null and the new function is called with value.
+    // ScrollView does not behave like this and this workaround is necessary.
+    node.setNativeView(cachedRef.current);
+  }, [node]);
+
   return [reduceAnimatedProps<TProps>(node), callbackRef];
 }