From 1a67214a3aee6dc3defb88fb9f9973ce32bd7919 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateo=20Guzm=C3=A1n?= Date: Mon, 3 Feb 2025 08:15:25 -0800 Subject: [PATCH] Make `SystraceRequestListener` internal (#49107) Summary: As part of the initiative to reduce the public API surface, this class can be internalized. I've checked there are [no relevant OSS usages](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+com.facebook.react.modules.fresco.SystraceRequestListener). ## Changelog: [INTERNAL] - Make com.facebook.react.modules.fresco.SystraceRequestListener internal Pull Request resolved: https://github.com/facebook/react-native/pull/49107 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: cortinico Differential Revision: D69046100 Pulled By: javache fbshipit-source-id: 0cb4c6eda385f458c3e4b02068ce77f2dd15af23 --- .../react-native/ReactAndroid/api/ReactAndroid.api | 14 -------------- .../modules/fresco/SystraceRequestListener.kt | 2 +- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index 3285764f339..db796db2513 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -3214,20 +3214,6 @@ public final class com/facebook/react/modules/fresco/ReactNetworkImageRequest$Co public static synthetic fun fromBuilderWithHeaders$default (Lcom/facebook/react/modules/fresco/ReactNetworkImageRequest$Companion;Lcom/facebook/imagepipeline/request/ImageRequestBuilder;Lcom/facebook/react/bridge/ReadableMap;Lcom/facebook/react/modules/fresco/ImageCacheControl;ILjava/lang/Object;)Lcom/facebook/react/modules/fresco/ReactNetworkImageRequest; } -public final class com/facebook/react/modules/fresco/SystraceRequestListener : com/facebook/imagepipeline/listener/BaseRequestListener { - public fun ()V - public fun onProducerEvent (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)V - public fun onProducerFinishWithCancellation (Ljava/lang/String;Ljava/lang/String;Ljava/util/Map;)V - public fun onProducerFinishWithFailure (Ljava/lang/String;Ljava/lang/String;Ljava/lang/Throwable;Ljava/util/Map;)V - public fun onProducerFinishWithSuccess (Ljava/lang/String;Ljava/lang/String;Ljava/util/Map;)V - public fun onProducerStart (Ljava/lang/String;Ljava/lang/String;)V - public fun onRequestCancellation (Ljava/lang/String;)V - public fun onRequestFailure (Lcom/facebook/imagepipeline/request/ImageRequest;Ljava/lang/String;Ljava/lang/Throwable;Z)V - public fun onRequestStart (Lcom/facebook/imagepipeline/request/ImageRequest;Ljava/lang/Object;Ljava/lang/String;Z)V - public fun onRequestSuccess (Lcom/facebook/imagepipeline/request/ImageRequest;Ljava/lang/String;Z)V - public fun requiresExtraMap (Ljava/lang/String;)Z -} - public final class com/facebook/react/modules/i18nmanager/I18nManagerModule : com/facebook/fbreact/specs/NativeI18nManagerSpec { public static final field Companion Lcom/facebook/react/modules/i18nmanager/I18nManagerModule$Companion; public static final field NAME Ljava/lang/String; diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/SystraceRequestListener.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/SystraceRequestListener.kt index 8553e1cbb10..11f38425072 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/SystraceRequestListener.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/SystraceRequestListener.kt @@ -13,7 +13,7 @@ import com.facebook.imagepipeline.request.ImageRequest import com.facebook.systrace.Systrace /** Logs requests to Systrace */ -public class SystraceRequestListener : BaseRequestListener() { +internal class SystraceRequestListener : BaseRequestListener() { private var currentId: Int = 0 private val producerId: MutableMap> = mutableMapOf() private val requestsId: MutableMap> = mutableMapOf()