Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make writable arrays and maps only shallowly writable

Browse Source 
Summary:
@public

The `WritableArray` and `WritableMap` interfaces currently require that nested arrays and maps also be writable. Nothing in our code actually relies on this, so we can relax this restriction and get useful properties.

For instance, it is now possible to construct a `JavaOnlyMap` (or array) that reuses `ReadableMap` and `ReadableArray` values by reference ( = structural sharing) instead of forcing a deep copy.

Reviewed By: kathryngray

Differential Revision: D16132580

fbshipit-source-id: 9f41189ebea2a82e775a7a4da8c357a5ce9c5b9d
This commit is contained in:
Moti Zilberman
2019-07-08 12:25:59 -07:00
committed by Facebook Github Bot
parent e0ae655787
commit 1a2937151b
6 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/bridge/WritableNativeArray.java
+2 -2
View File
@@ -42,7 +42,7 @@ public class WritableNativeArray extends ReadableNativeArray implements Writable
// Note: this consumes the map so do not reuse it.
@Override
public void pushArray(@Nullable WritableArray array) {
public void pushArray(@Nullable ReadableArray array) {
Assertions.assertCondition(
array == null || array instanceof WritableNativeArray, "Illegal type provided");
pushNativeArray((WritableNativeArray) array);
@@ -50,7 +50,7 @@ public class WritableNativeArray extends ReadableNativeArray implements Writable
// Note: this consumes the map so do not reuse it.
@Override
public void pushMap(@Nullable WritableMap map) {
public void pushMap(@Nullable ReadableMap map) {
Assertions.assertCondition(
map == null || map instanceof WritableNativeMap, "Illegal type provided");
pushNativeMap((WritableNativeMap) map);