From 1a12919dea5d6eb7c8c4cde6fa71761c9c75715e Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Fri, 6 Dec 2019 10:50:54 -0800 Subject: [PATCH] Fabric: Text Measuring: Using unlimited height during text measuring Summary: In the previous diff, we noted that the maximum height is not really important for text measurement. That diff make is in code. Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D18848585 fbshipit-source-id: 5fe0ea8f76487a50baa8a2e024663a85afcd9861 --- .../textlayoutmanager/platform/ios/RCTTextLayoutManager.mm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactCommon/fabric/textlayoutmanager/platform/ios/RCTTextLayoutManager.mm b/ReactCommon/fabric/textlayoutmanager/platform/ios/RCTTextLayoutManager.mm index 8c8c39d6aba..2474170f262 100644 --- a/ReactCommon/fabric/textlayoutmanager/platform/ios/RCTTextLayoutManager.mm +++ b/ReactCommon/fabric/textlayoutmanager/platform/ios/RCTTextLayoutManager.mm @@ -43,8 +43,8 @@ static NSLineBreakMode RCTNSLineBreakModeFromEllipsizeMode(EllipsizeMode ellipsi return {0, 0}; } - CGSize maximumSize = CGSize{layoutConstraints.maximumSize.width, - layoutConstraints.maximumSize.height}; + CGSize maximumSize = CGSize{layoutConstraints.maximumSize.width, CGFLOAT_MAX}; + NSTextStorage *textStorage = [self _textStorageAndLayoutManagerWithAttributesString:attributedString paragraphAttributes:paragraphAttributes size:maximumSize];