From 18e9ea211296d2ce553d3fb37411f18e31d00181 Mon Sep 17 00:00:00 2001
From: Dulmandakh <dulmandakh@gmail.com>
Date: Fri, 15 Jun 2018 14:26:20 -0700
Subject: [PATCH] Suppress lint errors in Dialog module. remove
 abortOnError=false (#19740)

Summary:
Suppress lint errors in Dialog module. remove abortOnError=false.

This might hide future problems, so removing it
``` gradle
lintOptions {
  abortOnError false
}
```

Builds locally just fine. But CI is failing for unknown reasons. https://circleci.com/gh/dulmandakh/react-native/265

RNTester will built without errors
Closes https://github.com/facebook/react-native/pull/19740

Differential Revision: D8450600

Pulled By: hramos

fbshipit-source-id: faf508a0c546af18a05ee224628f88b02a38ab9f
---
 RNTester/android/app/build.gradle                         | 4 ----
 .../com/facebook/react/modules/dialog/AlertFragment.java  | 2 ++
 .../react/modules/dialog/SupportAlertFragment.java        | 2 ++
 build.gradle                                              | 8 --------
 4 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/RNTester/android/app/build.gradle b/RNTester/android/app/build.gradle
index 2a2e3834c95..fdaa2753034 100644
--- a/RNTester/android/app/build.gradle
+++ b/RNTester/android/app/build.gradle
@@ -121,10 +121,6 @@ android {
         }
     }
 
-    lintOptions {
-        abortOnError false
-    }
-
     // applicationVariants are e.g. debug, release
     applicationVariants.all { variant ->
         variant.outputs.each { output ->
diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/AlertFragment.java b/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/AlertFragment.java
index a233b9130fc..ecb0229e32b 100644
--- a/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/AlertFragment.java
+++ b/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/AlertFragment.java
@@ -9,6 +9,7 @@ package com.facebook.react.modules.dialog;
 
 import javax.annotation.Nullable;
 
+import android.annotation.SuppressLint;
 import android.app.AlertDialog;
 import android.app.Dialog;
 import android.app.DialogFragment;
@@ -34,6 +35,7 @@ public class AlertFragment extends DialogFragment implements DialogInterface.OnC
       mListener = null;
   }
 
+  @SuppressLint("ValidFragment")
   public AlertFragment(@Nullable DialogModule.AlertFragmentListener listener, Bundle arguments) {
     mListener = listener;
     setArguments(arguments);
diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/SupportAlertFragment.java b/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/SupportAlertFragment.java
index dea3c71a6f6..0b360683d4d 100644
--- a/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/SupportAlertFragment.java
+++ b/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/SupportAlertFragment.java
@@ -9,6 +9,7 @@ package com.facebook.react.modules.dialog;
 
 import javax.annotation.Nullable;
 
+import android.annotation.SuppressLint;
 import android.app.Dialog;
 import android.content.DialogInterface;
 import android.os.Bundle;
@@ -27,6 +28,7 @@ public class SupportAlertFragment extends DialogFragment implements DialogInterf
       mListener = null;
   }
 
+  @SuppressLint("ValidFragment")
   public SupportAlertFragment(@Nullable DialogModule.AlertFragmentListener listener, Bundle arguments) {
     mListener = listener;
     setArguments(arguments);
diff --git a/build.gradle b/build.gradle
index c9c43736f86..71634a0cbef 100644
--- a/build.gradle
+++ b/build.gradle
@@ -35,12 +35,4 @@ allprojects {
             url "$androidSdk/extras/m2repository/"
         }
     }
-
-    project.configurations.all {
-        resolutionStrategy.eachDependency { details ->
-            if (details.requested.group == 'com.facebook.soloader') {
-                details.useVersion "0.3.0"
-            }
-        }
-    }
 }