From 18992d2ebec3e42e9f5b048799dd3be17bf44558 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateo=20Guzm=C3=A1n?= Date: Tue, 11 Feb 2025 04:03:09 -0800 Subject: [PATCH] Make `ReactPackageLogger` internal (#49236) Summary: As part of the initiative to reduce the public API surface, this class can be internalized. I've checked there are [no relevant OSS usages](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+com.facebook.react.ReactPackageLogger). ## Changelog: [INTERNAL] - Make com.facebook.react.ReactPackageLogger internal Pull Request resolved: https://github.com/facebook/react-native/pull/49236 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: cipolleschi Differential Revision: D69307159 Pulled By: cortinico fbshipit-source-id: 397be796bc9cc7acd633b461d40fcf1989708b4c --- packages/react-native/ReactAndroid/api/ReactAndroid.api | 5 ----- .../src/main/java/com/facebook/react/ReactPackageLogger.kt | 7 +++---- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index 99d87e7380c..bee59f6e7a0 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -349,11 +349,6 @@ public abstract interface class com/facebook/react/ReactPackage { public fun getModule (Ljava/lang/String;Lcom/facebook/react/bridge/ReactApplicationContext;)Lcom/facebook/react/bridge/NativeModule; } -public abstract interface class com/facebook/react/ReactPackageLogger { - public abstract fun endProcessPackage ()V - public abstract fun startProcessPackage ()V -} - public abstract class com/facebook/react/ReactPackageTurboModuleManagerDelegate : com/facebook/react/internal/turbomodule/core/TurboModuleManagerDelegate { protected fun (Lcom/facebook/react/bridge/ReactApplicationContext;Ljava/util/List;)V protected fun (Lcom/facebook/react/bridge/ReactApplicationContext;Ljava/util/List;Lcom/facebook/jni/HybridData;)V diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageLogger.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageLogger.kt index 5634de6244f..f031abdf2e4 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageLogger.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageLogger.kt @@ -8,9 +8,8 @@ package com.facebook.react /** Interface for the bridge to call for TTI start and end markers. */ -public interface ReactPackageLogger { +internal interface ReactPackageLogger { + fun startProcessPackage(): Unit - public fun startProcessPackage(): Unit - - public fun endProcessPackage(): Unit + fun endProcessPackage(): Unit }